You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/08 04:18:00 UTC
[GitHub] [flink] masteryhx opened a new pull request, #19399: [FLINK-26852][state] Avoid RocksDBMapState#clear swallowing related e…
masteryhx opened a new pull request, #19399:
URL: https://github.com/apache/flink/pull/19399
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request makes sure that RocksDBException will be wrapped and thrown in RocksDBMapState#clear
## Brief change log
- Use `FlinkRuntimeException` to wrap `RocksDBException` and rethrown in `RocksDBMapState#clear`.
## Verifying this change
- Added `testMapStateClear()` in `EmbeddedRocksDBStateBackendTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19399: [FLINK-26852][state] Avoid RocksDBMapState#clear swallowing related e…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19399:
URL: https://github.com/apache/flink/pull/19399#issuecomment-1092428105
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6a9ef17059c670727f952d3b13cfa429e2c5a60d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6a9ef17059c670727f952d3b13cfa429e2c5a60d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a9ef17059c670727f952d3b13cfa429e2c5a60d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a diff in pull request #19399: [FLINK-26852][state] Avoid RocksDBMapState#clear swallowing related e…
Posted by GitBox <gi...@apache.org>.
Myasuka commented on code in PR #19399:
URL: https://github.com/apache/flink/pull/19399#discussion_r845764781
##########
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackendTest.java:
##########
@@ -619,6 +623,25 @@ public void testSharedIncrementalStateDeRegistration() throws Exception {
}
}
+ @Test(expected = FlinkRuntimeException.class)
+ public void testMapStateClear() throws Exception {
+ setupRocksKeyedStateBackend();
+ keyedStateBackend = spy(keyedStateBackend);
+ MapStateDescriptor<Integer, String> kvId =
+ new MapStateDescriptor<>("id", Integer.class, String.class);
+ MapState<Integer, String> state =
+ keyedStateBackend.getPartitionedState(
+ VoidNamespace.INSTANCE, VoidNamespaceSerializer.INSTANCE, kvId);
+
+ doAnswer(
+ invocationOnMock -> {
+ throw new RocksDBException("Artificial failure");
+ })
+ .when(keyedStateBackend)
+ .getWriteOptions();
Review Comment:
We could change the implementation of state#clear in the future, and we might not call `keyedStateBackend`, however, we would not change the kernel logic of mapState#clear that we would always create a rocksdb iterator.
I think the logic of spying on creating a iterator could be referred:
~~~ java
doAnswer(
new Answer<Object>() {
@Override
public Object answer(InvocationOnMock invocationOnMock)
throws Throwable {
RocksIterator rocksIterator =
spy((RocksIterator) invocationOnMock.callRealMethod());
allCreatedCloseables.add(rocksIterator);
return rocksIterator;
}
})
.when(keyedStateBackend.db)
.newIterator(any(ColumnFamilyHandle.class), any(ReadOptions.class));
~~~
##########
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackendTest.java:
##########
@@ -89,9 +93,9 @@
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.reset;
+import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.internal.verification.VerificationModeFactory.times;
-import static org.powermock.api.mockito.PowerMockito.spy;
Review Comment:
Why we have to change the `spy` implementation here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka merged pull request #19399: [FLINK-26852][state] Avoid RocksDBMapState#clear swallowing related e…
Posted by GitBox <gi...@apache.org>.
Myasuka merged PR #19399:
URL: https://github.com/apache/flink/pull/19399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] masteryhx commented on a diff in pull request #19399: [FLINK-26852][state] Avoid RocksDBMapState#clear swallowing related e…
Posted by GitBox <gi...@apache.org>.
masteryhx commented on code in PR #19399:
URL: https://github.com/apache/flink/pull/19399#discussion_r845784809
##########
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackendTest.java:
##########
@@ -619,6 +623,25 @@ public void testSharedIncrementalStateDeRegistration() throws Exception {
}
}
+ @Test(expected = FlinkRuntimeException.class)
+ public void testMapStateClear() throws Exception {
+ setupRocksKeyedStateBackend();
+ keyedStateBackend = spy(keyedStateBackend);
+ MapStateDescriptor<Integer, String> kvId =
+ new MapStateDescriptor<>("id", Integer.class, String.class);
+ MapState<Integer, String> state =
+ keyedStateBackend.getPartitionedState(
+ VoidNamespace.INSTANCE, VoidNamespaceSerializer.INSTANCE, kvId);
+
+ doAnswer(
+ invocationOnMock -> {
+ throw new RocksDBException("Artificial failure");
+ })
+ .when(keyedStateBackend)
+ .getWriteOptions();
Review Comment:
I agree. I have mocked the `newIterator` to throw `RocksDBException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] masteryhx commented on a diff in pull request #19399: [FLINK-26852][state] Avoid RocksDBMapState#clear swallowing related e…
Posted by GitBox <gi...@apache.org>.
masteryhx commented on code in PR #19399:
URL: https://github.com/apache/flink/pull/19399#discussion_r845783236
##########
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackendTest.java:
##########
@@ -89,9 +93,9 @@
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.reset;
+import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.internal.verification.VerificationModeFactory.times;
-import static org.powermock.api.mockito.PowerMockito.spy;
Review Comment:
Used the previous implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org