[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #228: [MNG-7665] Update Jetty to latest Java8 capable version

[GitBox <gi...@apache.org>]

cstamas commented on code in PR #228:
URL: https://github.com/apache/maven-integration-testing/pull/228#discussion_r1067347100


##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4470AuthenticatedDeploymentToProxyTest.java:
##########
@@ -92,7 +89,7 @@ public void handle( String target, Request baseRequest, HttpServletRequest reque
                 if ( auth != null )
                 {
                     auth = auth.substring( auth.indexOf( ' ' ) + 1 ).trim();
-                    auth = B64Code.decode( auth, StandardCharsets.US_ASCII.name() );
+                    auth = new String( java.util.Base64.getDecoder().decode( auth ), StandardCharsets.US_ASCII );

Review Comment:
   no special reason, I believe at one point both classes were present (Jetty deprecated B64code and j.u.Base64) and my IDE just choose to fully name it? Should I add it to import?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org