You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/11/15 14:34:27 UTC
Review Request 63838: ambari-server setup should surface GPL software
agreement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-22453
https://issues.apache.org/jira/browse/AMBARI-22453
Repository: ambari
Description
-------
* Ask the user if they are okay with installing GPL license software
* Surface the license agreement subtext, for now use placeholder
* Save the result in ambari.properties
* The user selection should be available through API for the client and also stack scripts
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 91df506478
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 0bd6af6611
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d8712f2c75
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 0b048ad089
ambari-server/src/main/python/ambari-server.py 60c60052cc
ambari-server/src/main/python/ambari_server/serverConfiguration.py c7ac13476f
ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621
Diff: https://reviews.apache.org/r/63838/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 63838: ambari-server setup should surface GPL
software agreement
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/#review191067
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 734-735 (patched)
<https://reviews.apache.org/r/63838/#comment268661>
I'd prefer type `Boolean` (and possibly default value of `Boolean.FALSE`).
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 5332 (patched)
<https://reviews.apache.org/r/63838/#comment268659>
Looks like this would throw NPE if the property `gpl.license.accepted` is not present in `ambari.properties`. How about using `Boolean.valueOf(String)`?
- Attila Doroszlai
On Nov. 15, 2017, 3:34 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63838/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2017, 3:34 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-22453
> https://issues.apache.org/jira/browse/AMBARI-22453
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Ask the user if they are okay with installing GPL license software
> * Surface the license agreement subtext, for now use placeholder
> * Save the result in ambari.properties
> * The user selection should be available through API for the client and also stack scripts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 91df506478
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 0bd6af6611
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d8712f2c75
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 0b048ad089
> ambari-server/src/main/python/ambari-server.py 60c60052cc
> ambari-server/src/main/python/ambari_server/serverConfiguration.py c7ac13476f
> ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621
>
>
> Diff: https://reviews.apache.org/r/63838/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 63838: ambari-server setup should surface GPL
software agreement
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/#review191064
-----------------------------------------------------------
Fix it, then Ship it!
Overall, the patch looks fine, just a minor javadoc issue that should be addressed.
Thanks.
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 729 (patched)
<https://reviews.apache.org/r/63838/#comment268650>
Minor issue: This javadoc comment doesn't reflect the actual property being added. This just looks like a copy and paste error, but is probably worth fixing for the sake of clarity.
- Robert Nettleton
On Nov. 15, 2017, 2:34 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63838/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2017, 2:34 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-22453
> https://issues.apache.org/jira/browse/AMBARI-22453
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Ask the user if they are okay with installing GPL license software
> * Surface the license agreement subtext, for now use placeholder
> * Save the result in ambari.properties
> * The user selection should be available through API for the client and also stack scripts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 91df506478
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 0bd6af6611
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d8712f2c75
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 0b048ad089
> ambari-server/src/main/python/ambari-server.py 60c60052cc
> ambari-server/src/main/python/ambari_server/serverConfiguration.py c7ac13476f
> ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621
>
>
> Diff: https://reviews.apache.org/r/63838/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 63838: ambari-server setup should surface GPL
software agreement
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/#review191077
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/python/ambari-server.py
Lines 516 (patched)
<https://reviews.apache.org/r/63838/#comment268670>
Rename to be more explicit based o nthe realtime board: --enable-lzo-under-gpl-license
- Sid Wagle
On Nov. 15, 2017, 2:34 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63838/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2017, 2:34 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-22453
> https://issues.apache.org/jira/browse/AMBARI-22453
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Ask the user if they are okay with installing GPL license software
> * Surface the license agreement subtext, for now use placeholder
> * Save the result in ambari.properties
> * The user selection should be available through API for the client and also stack scripts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 91df506478
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 0bd6af6611
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d8712f2c75
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 0b048ad089
> ambari-server/src/main/python/ambari-server.py 60c60052cc
> ambari-server/src/main/python/ambari_server/serverConfiguration.py c7ac13476f
> ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621
>
>
> Diff: https://reviews.apache.org/r/63838/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>