You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stricklandrbls (via GitHub)" <gi...@apache.org> on 2023/04/05 14:08:34 UTC
[GitHub] [daffodil-vscode] stricklandrbls opened a new pull request, #570: Clear selection data when ephemeral windows close
stricklandrbls opened a new pull request, #570:
URL: https://github.com/apache/daffodil-vscode/pull/570
- Lingering selection data, especially in SBM, would cause issues when trying to search / replace.
Closes #561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #570: Clear selection data when ephemeral windows close
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #570:
URL: https://github.com/apache/daffodil-vscode/pull/570#discussion_r1158584768
##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -220,6 +220,7 @@ limitations under the License.
(targetLine == 0 ? 0 : targetLine - 1) * lineHeight
}
closeEphemeralWindows()
+ clearDataDisplays()
Review Comment:
Is there any time where we'd close the ephemeral window and not clear the data display? If not, let's just clear the data display ni the close ephemeral window function instead to make it simpler and less error prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #570: Clear selection data when ephemeral windows close
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell merged PR #570:
URL: https://github.com/apache/daffodil-vscode/pull/570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on a diff in pull request #570: Clear selection data when ephemeral windows close
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on code in PR #570:
URL: https://github.com/apache/daffodil-vscode/pull/570#discussion_r1158618220
##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -220,6 +220,7 @@ limitations under the License.
(targetLine == 0 ? 0 : targetLine - 1) * lineHeight
}
closeEphemeralWindows()
+ clearDataDisplays()
Review Comment:
That's how I originally had it set up but there was one instance where we should close the window but not clear. I'm trying to think of what it was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on a diff in pull request #570: Clear selection data when ephemeral windows close
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on code in PR #570:
URL: https://github.com/apache/daffodil-vscode/pull/570#discussion_r1158618220
##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -220,6 +220,7 @@ limitations under the License.
(targetLine == 0 ? 0 : targetLine - 1) * lineHeight
}
closeEphemeralWindows()
+ clearDataDisplays()
Review Comment:
That's how I originally had it set up but there was one instance where we should close the window but not clear. I'm trying to think of what it was.
It may have been an artifact from when I was first designing that window but I think keeping them separate until the [Svelte Compartmentatliztation](https://github.com/apache/daffodil-vscode/issues/572) implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org