You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "pepijnve (via GitHub)" <gi...@apache.org> on 2025/07/11 09:51:14 UTC
[PR] Use tokio::task::coop::poll_proceed by default in CooperativeStream [datafusion]
pepijnve opened a new pull request, #16748:
URL: https://github.com/apache/datafusion/pull/16748
## Which issue does this PR close?
- Closes #16489.
## Rationale for this change
Using `poll_proceed` instead of `consume_budget` allows for budget consumption rollback which lets tasks attempt more avenues to make progress.
## What changes are included in this PR?
- Switch the default `coop` implementation to the one based on `poll_proceed`
## Are these changes tested?
Covered by `coop` test cases.
## Are there any user-facing changes?
Tokio version dependency bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use tokio::task::coop::poll_proceed by default in CooperativeStream [datafusion]
Posted by "pepijnve (via GitHub)" <gi...@apache.org>.
pepijnve commented on PR #16748:
URL: https://github.com/apache/datafusion/pull/16748#issuecomment-3061578448
Draft status since this depends on the current git version of Tokio. Can be considered for merging after the next Tokio scheduled release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use tokio::task::coop::poll_proceed by default in CooperativeStream [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16748:
URL: https://github.com/apache/datafusion/pull/16748#issuecomment-3137814662
Thanks again @pepijnve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use tokio::task::coop::poll_proceed by default in CooperativeStream [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #16748:
URL: https://github.com/apache/datafusion/pull/16748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use tokio::task::coop::poll_proceed by default in CooperativeStream [datafusion]
Posted by "pepijnve (via GitHub)" <gi...@apache.org>.
pepijnve commented on PR #16748:
URL: https://github.com/apache/datafusion/pull/16748#issuecomment-3122058583
With the release of Tokio 1.47.0 this is now a candidate for merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use tokio::task::coop::poll_proceed by default in CooperativeStream [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16748:
URL: https://github.com/apache/datafusion/pull/16748#issuecomment-3137692500
I merged this PR up to resolve a conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org