You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/08/31 04:46:19 UTC

[kudu-CR](branch-1.5.x) java-client: improve error messages when failing to connect to secure cluster 

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7915

Change subject: java-client: improve error messages when failing to connect to secure cluster
......................................................................

java-client: improve error messages when failing to connect to secure cluster

Cleans up the error handling in Connection.java so that is passes
through non-recoverable exceptions, and improves the error which results
from attempting to connect to a secure cluster with an unauthenticated
client. Example of the new error:

    org.apache.kudu.client.NonRecoverableException:
      Couldn't find a valid master in (nightly512-1.gce.cloudera.com:7051).
      Exceptions received:
          org.apache.kudu.client.NonRecoverableException:
              Server requires Kerberos, but this client is not authenticated (kinit)

Change-Id: I41c3229dcda284dce57cb6f6930efe3b50fa9698
Reviewed-on: http://gerrit.cloudera.org:8080/7824
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 986e8de63d8687421c476de07c4e889129062637)
---
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
4 files changed, 109 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/7915/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41c3229dcda284dce57cb6f6930efe3b50fa9698
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>

[kudu-CR](branch-1.5.x) java-client: improve error messages when failing to connect to secure cluster

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: java-client: improve error messages when failing to connect to secure cluster
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c3229dcda284dce57cb6f6930efe3b50fa9698
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-HasComments: No

[kudu-CR](branch-1.5.x) java-client: improve error messages when failing to connect to secure cluster

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: java-client: improve error messages when failing to connect to secure cluster
......................................................................


java-client: improve error messages when failing to connect to secure cluster

Cleans up the error handling in Connection.java so that is passes
through non-recoverable exceptions, and improves the error which results
from attempting to connect to a secure cluster with an unauthenticated
client. Example of the new error:

    org.apache.kudu.client.NonRecoverableException:
      Couldn't find a valid master in (nightly512-1.gce.cloudera.com:7051).
      Exceptions received:
          org.apache.kudu.client.NonRecoverableException:
              Server requires Kerberos, but this client is not authenticated (kinit)

Change-Id: I41c3229dcda284dce57cb6f6930efe3b50fa9698
Reviewed-on: http://gerrit.cloudera.org:8080/7824
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 986e8de63d8687421c476de07c4e889129062637)
Reviewed-on: http://gerrit.cloudera.org:8080/7915
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Dan Burkert <da...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
4 files changed, 109 insertions(+), 77 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41c3229dcda284dce57cb6f6930efe3b50fa9698
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR](branch-1.5.x) java-client: improve error messages when failing to connect to secure cluster

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: java-client: improve error messages when failing to connect to secure cluster
......................................................................


Patch Set 1:

This keeps running into flakes, manually verifying.

-- 
To view, visit http://gerrit.cloudera.org:8080/7915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c3229dcda284dce57cb6f6930efe3b50fa9698
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR](branch-1.5.x) java-client: improve error messages when failing to connect to secure cluster

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: java-client: improve error messages when failing to connect to secure cluster
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c3229dcda284dce57cb6f6930efe3b50fa9698
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-HasComments: No