[GitHub] [cassandra-sidecar] frankgh commented on a diff in pull request #30: CASSANDRASC-38 Add endpoint to list snapshot files

[GitBox <gi...@apache.org>]

frankgh commented on code in PR #30:
URL: https://github.com/apache/cassandra-sidecar/pull/30#discussion_r908879071


##########
src/test/java/org/apache/cassandra/sidecar/snapshots/AbstractSnapshotPathBuilderTest.java:
##########
@@ -109,149 +129,16 @@ void setup() throws IOException
         instance = initialize(vertx, mockInstancesConfig);
     }
 
+    @SuppressWarnings("ResultOfMethodCallIgnored")
     @AfterEach
     void clear()
     {
-        assertThat(dataDir0.delete());
-        assertThat(dataDir1.delete());
+        dataDir0.delete();
+        dataDir1.delete();
     }
 
     abstract SnapshotPathBuilder initialize(Vertx vertx, InstancesConfig instancesConfig);
 
-    @Test

Review Comment:
   these are really unit tests, moved them to `StreamSSTableComponentRequestTest`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org