You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/05/03 08:14:46 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04

adamdebreceni commented on code in PR #1319:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319#discussion_r863559349


##########
aptitude.sh:
##########
@@ -44,7 +44,7 @@ bootstrap_cmake(){
 build_deps(){
     ## need to account for debian
     compiler_pkgs="gcc g++"
-    if [[ "$OS" = Ubuntu* ]]; then
+    if [[ "$OS" = Ubuntu* && "$OS_MAJOR" -lt 22 ]]; then

Review Comment:
   are these required changes for a successful build on 22.04? if so, an accompanying ci job could ensure that the build stays successful



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org