You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "suibianwanwan (Jira)" <ji...@apache.org> on 2024/08/18 06:40:00 UTC

[jira] [Commented] (CALCITE-6534) Fix type mismatches when pulling up Calc nodes in JoinUnifyRule

    [ https://issues.apache.org/jira/browse/CALCITE-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874615#comment-17874615 ] 

suibianwanwan commented on CALCITE-6534:
----------------------------------------

Although these two issues address different problems, their implementations share many similarities. Both essentially involve handling null-if-null logic when joins are equivalence, so I'll fix them in the same PR.

> Fix type mismatches when pulling up Calc nodes in JoinUnifyRule
> ---------------------------------------------------------------
>
>                 Key: CALCITE-6534
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6534
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: suibianwanwan
>            Assignee: suibianwanwan
>            Priority: Minor
>
> In JoinOnLeftCalcUnifyRule, JoinOnRIghtCalcUnifyRule, JoinOnCalcUnifyRule, calcite tries to pull up the calc operator to make Query equivalent to target . In [CALCITE-6501|https://issues.apache.org/jira/browse/CALCITE-6501], for the case where the assert is due to a difference in nullablity, we do an early intercept and return null. This will result in some cases that can be rewritten not being able to be rewritten.
> We can fix nullablility if this rewrite maintains semantics



--
This message was sent by Atlassian Jira
(v8.20.10#820010)