You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/04/25 15:12:57 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1590: SOLR-16393: Tweak v2 "create alias" API to be more REST-ful
gerlowskija opened a new pull request, #1590:
URL: https://github.com/apache/solr/pull/1590
https://issues.apache.org/jira/browse/SOLR-16393
# Description
Solr is currently making slow progress in moving its v2 APIs in a more REST-ful direction. Many APIs have been improved, but many remaining including the commonly used API to create aliases.
# Solution
This commit makes various cosmetic improvements to Solr's v2 create alias API, to bring it more into line with the more REST-ful v2 design. This mostly includes moving the API to the new `/api/aliases` path, and restructuring the v2 request body to be a bit more intuitive. An example request now looks like:
```
POST /api/aliases
{
"name": "somethingTemporalThisWayComes",
"routers" : [
{
"type": "time",
"field": "evt_dt",
"start":"NOW/MINUTE",
"interval":"+2HOUR",
"maxFutureMs":"14400000"
}
]
"create-collection" : {
"config":"_default",
"numShards": 3,
"tlogReplicas":1,
"pullReplicas":1,
"properties" : {
"foobar":"bazbam"
}
}
```
# Tests
Existing alias tests continue to pass. New unit tests added in CreateAliasAPITest.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1590: SOLR-16393: Tweak v2 "create alias" API to be more REST-ful
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1590:
URL: https://github.com/apache/solr/pull/1590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1590: SOLR-16393: Tweak v2 "create alias" API to be more REST-ful
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1590:
URL: https://github.com/apache/solr/pull/1590#issuecomment-1522017625
With the exception of a few tests that are unique to this PR, the code here all comes from https://github.com/apache/solr/pull/1453. I'm in the process of splitting that PR up into smaller chunks, of which this is one.
The code here should be good to go, except for a CHANGES.txt entry I'll add closer to merge-time to avoid the inevitable conflicts that file has. Since the code has been up for review for some weeks under that other PR, I'll probably aim to commit here in the next few days once I'm confident that the tests look good? Fingers crossed I guess...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org