You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Eric Newton <er...@gmail.com> on 2015/04/02 00:05:10 UTC
Re: Review Request 32224: ACCUMULO-3423
> On March 23, 2015, 5:39 p.m., kturner wrote:
> > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java, line 1154
> > <https://reviews.apache.org/r/32224/diff/1/?file=899488#file899488line1154>
> >
> > Why does this write to root and meta?
There could be a marker at the meta and/or root level, mark them both as unused. Comment added.
> On March 23, 2015, 5:39 p.m., kturner wrote:
> > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java, line 1199
> > <https://reviews.apache.org/r/32224/diff/1/?file=899488#file899488line1199>
> >
> > What prevents unused logs from being fetched?
Good catch. I've fixed the code.
> On March 23, 2015, 5:39 p.m., kturner wrote:
> > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java, line 232
> > <https://reviews.apache.org/r/32224/diff/1/?file=899498#file899498line232>
> >
> > Is this code still needed? Would it still be used for upgrade case?
I tried to make ACCUMULO-3423 as conservative as possible (yes, really!). To that end, log entries are put onto tablets for recovery, so all the trickiness of recovery could stay the same.
> On March 23, 2015, 5:39 p.m., kturner wrote:
> > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java, line 273
> > <https://reviews.apache.org/r/32224/diff/1/?file=899498#file899498line273>
> >
> > Would you expect this method to be called if the logs had already been marked as unused? It seems like it should not, but I am not 100% sure. Thinking that if this is an unexpected case that a sanity check might be worthwhile.
The metadata update to unassign a tablet creates the log references in the same mutation. It should never be the case that the tablet is ASSIGNED to dead server and not need to fetch the logs.
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32224/#review77413
-----------------------------------------------------------
On March 19, 2015, 4:42 p.m., Eric Newton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32224/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 4:42 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-3423
> https://issues.apache.org/jira/browse/ACCUMULO-3423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Faster WAL rollovers
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java 6a5c74a
> core/src/main/java/org/apache/accumulo/core/conf/Property.java 2403915
> core/src/main/java/org/apache/accumulo/core/metadata/RootTable.java 24148b1
> core/src/main/java/org/apache/accumulo/core/metadata/schema/MetadataSchema.java 534dd7f
> core/src/main/java/org/apache/accumulo/core/tabletserver/log/LogEntry.java 25d0f32
> core/src/test/java/org/apache/accumulo/core/metadata/MetadataTableSchemaTest.java PRE-CREATION
> server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java fc26ca4
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e5bdded
> server/base/src/main/java/org/apache/accumulo/server/master/state/MetaDataStateStore.java 7ee6f0c
> server/base/src/main/java/org/apache/accumulo/server/master/state/MetaDataTableScanner.java 9be5a67
> server/base/src/main/java/org/apache/accumulo/server/master/state/TabletLocationState.java b24b562
> server/base/src/main/java/org/apache/accumulo/server/master/state/TabletStateStore.java 5413e31
> server/base/src/main/java/org/apache/accumulo/server/master/state/ZooTabletStateStore.java ab99396
> server/base/src/main/java/org/apache/accumulo/server/replication/StatusUtil.java 898e3d4
> server/base/src/main/java/org/apache/accumulo/server/util/ListVolumesUsed.java e90d1dd
> server/base/src/main/java/org/apache/accumulo/server/util/MasterMetadataUtil.java 4ca2d64
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 10cd749
> server/base/src/main/java/org/apache/accumulo/server/util/ReplicationTableUtil.java af02a8d
> server/base/src/test/java/org/apache/accumulo/server/util/ReplicationTableUtilTest.java b1010c2
> server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java 1735c0d
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java c8d5cd6
> server/gc/src/main/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferences.java 3a32727
> server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogsTest.java 5801faa
> server/gc/src/test/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferencesTest.java 23db83a
> server/master/src/main/java/org/apache/accumulo/master/Master.java 3762f32
> server/master/src/main/java/org/apache/accumulo/master/MasterClientServiceHandler.java f73c236
> server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java d097d75
> server/master/src/main/java/org/apache/accumulo/master/replication/WorkMaker.java 8532e1b
> server/master/src/main/java/org/apache/accumulo/master/state/MergeStats.java 44f229e
> server/master/src/test/java/org/apache/accumulo/master/ReplicationOperationsImplTest.java a127dcd
> server/master/src/test/java/org/apache/accumulo/master/TestMergeState.java b0240f1
> server/master/src/test/java/org/apache/accumulo/master/state/RootTabletStateStoreTest.java abceae4
> server/tserver/src/main/findbugs/exclude-filter.xml 47dd1f5
> server/tserver/src/main/java/org/apache/accumulo/server/GarbageCollectionLogger.java 8f3785e
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletLevel.java PRE-CREATION
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 662ee31
> server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 5acf5eb
> server/tserver/src/main/java/org/apache/accumulo/tserver/log/SortedLogRecovery.java c4d9fab
> server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 711c497
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java b4814e4
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java 594d9c5
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 6152500
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java 4bc05a6
> test/src/main/java/org/apache/accumulo/test/performance/thrift/NullTserver.java b429607
> test/src/test/java/org/apache/accumulo/proxy/ProxyDurabilityIT.java 404a8fd
> test/src/test/java/org/apache/accumulo/test/BadDeleteMarkersCreatedIT.java 25337b2
> test/src/test/java/org/apache/accumulo/test/BalanceIT.java f793925
> test/src/test/java/org/apache/accumulo/test/CleanWalIT.java f553be8
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java bd00f02
> test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java b78a311
> test/src/test/java/org/apache/accumulo/test/NoMutationRecoveryIT.java 6a9975c
> test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 56a6a70
> test/src/test/java/org/apache/accumulo/test/functional/WALSunnyDayIT.java PRE-CREATION
> test/src/test/java/org/apache/accumulo/test/functional/WatchTheWatchCountIT.java bd0555b
> test/src/test/java/org/apache/accumulo/test/performance/RollWALPerformanceIT.java PRE-CREATION
> test/src/test/java/org/apache/accumulo/test/replication/GarbageCollectorCommunicatesWithTServersIT.java 5b89d9c
> test/src/test/java/org/apache/accumulo/test/replication/MultiInstanceReplicationIT.java 9dec16e
> test/src/test/java/org/apache/accumulo/test/replication/ReplicationIT.java 54348db
>
> Diff: https://reviews.apache.org/r/32224/diff/
>
>
> Testing
> -------
>
> Ran all tests, except RandomWalk.
>
>
> Thanks,
>
> Eric Newton
>
>