You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "messere1 (via GitHub)" <gi...@apache.org> on 2026/08/11 03:54:57 UTC
[I] [studio][Bug] Audit cleanup allows duplicate destructive submissions [rocketmq-dashboard]
messere1 opened a new issue, #1570:
URL: https://github.com/apache/rocketmq-dashboard/issues/1570
### Before Creating the Bug Report
- [x] I found a reproducible UI bug.
- [x] I searched existing issues and pull requests for audit cleanup duplicate submission, submitting state, and double clicks.
- [x] I confirmed the bug exists on the current rocketmq-studio branch.
### Describe the Bug
The Audit page cleanup modal calls cleanupAuditLogs directly from onOk but does not track a cleanup-in-progress state.
On a slow response, users can click the confirmation button repeatedly. Each click starts another destructive cleanup request for the same retention window. The modal also remains cancellable while the request is in flight, so the operation can continue after the UI implies it was cancelled.
### Expected Behavior
- Start at most one cleanup request while a previous cleanup is pending.
- Show the modal confirmation button in a loading state.
- Prevent closing/cancelling the modal until the current cleanup request settles.
- Restore controls after either success or failure.
- Keep the existing refresh behavior after a successful cleanup.
- Add a regression test proving repeated confirmation produces one service call.
### Affected Area
RocketMQ Studio Track 1, Audit Logs page.
### Proposed Scope
Limit the change to the Audit page and its focused frontend test. No backend or API-contract changes are required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [studio][Bug] Audit cleanup allows duplicate destructive submissions [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #1570:
URL: https://github.com/apache/rocketmq-dashboard/issues/1570#issuecomment-5389248826
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [studio][Bug] Audit cleanup allows duplicate destructive submissions [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #1570: [studio][Bug] Audit cleanup allows duplicate destructive submissions
URL: https://github.com/apache/rocketmq-dashboard/issues/1570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [studio][Bug] Audit cleanup allows duplicate destructive submissions [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #1570:
URL: https://github.com/apache/rocketmq-dashboard/issues/1570#issuecomment-5248863434
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
The reported issue is valid. The Audit page cleanup modal calls `cleanupAuditLogs` directly from `onOk` without tracking a `cleaning` state, allowing duplicate destructive submissions on rapid clicks.
**Root Cause:** Missing `cleanupInProgress` state guard in the confirmation modal. The modal remains cancellable during the in-flight request.
**Severity:** Medium — can trigger multiple destructive audit cleanup operations.
An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org