You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2017/10/16 13:50:26 UTC
[isis] branch dev/2.0.0/ISIS-1742-remove-deprecations updated:
ISIS-1742: removes CommandService#startTransaction
This is an automated email from the ASF dual-hosted git repository.
danhaywood pushed a commit to branch dev/2.0.0/ISIS-1742-remove-deprecations
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/dev/2.0.0/ISIS-1742-remove-deprecations by this push:
new cd11e77 ISIS-1742: removes CommandService#startTransaction
cd11e77 is described below
commit cd11e77e196c959864c186c495b9146624692227
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Mon Oct 16 14:50:10 2017 +0100
ISIS-1742: removes CommandService#startTransaction
---
...rgsvc_application-layer-spi_CommandService.adoc | 15 +++-----
.../services/command/spi/CommandService.java | 11 +-----
.../services/command/CommandServiceDefault.java | 7 ----
todo-deprecation-list.txt | 45 +++++++++++++---------
4 files changed, 32 insertions(+), 46 deletions(-)
diff --git a/adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-spi_CommandService.adoc b/adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-spi_CommandService.adoc
index c2096f0..aa34fef 100644
--- a/adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-spi_CommandService.adoc
+++ b/adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-spi_CommandService.adoc
@@ -51,21 +51,16 @@ The `CommandService` service defines the following very simple API:
----
public interface CommandService {
Command create(); // <1>
- @Deprecated
- void startTransaction(Command command, UUID transactionId); // <2>
- boolean persistIfPossible(Command command); // <3>
- void complete(Command command); // <4>
+ boolean persistIfPossible(Command command); // <2>
+ void complete(Command command); // <3>
}
----
<1> Instantiate the appropriate instance of the `Command` (as defined by the
xref:../rgsvc/rgsvc.adoc#_rgsvc_application-layer-api_CommandContext[`CommandContext`] service). Its members will be populated automatically by
the framework.
-<2> this method (as of `1.13.0`) is *NO LONGER CALLED* and is deprecated: the framework automatically populates the ``Command``'s `timestamp`,
-`user` and `transactionId` fields, so there is no need for the service implementation to initialize any of these. In
-particular, the ``Command`` will already have been initialized with the provided `transactionId` argument.
-<3> Set the hint that the `Command` should be persisted if possible (when completed, see below).
-<4> "Complete" the command, typically meaning that the command should be persisted it if its `Command#getPersistence()`
-flag and persistence hint (`Command#isPersistHint()`) indicate that it should be. +
+<2> Set the hint that the `Command` should be persisted if possible (when completed, see below).
+<3> "Complete" the command, typically meaning that the command should be persisted it if its `Command#getPersistence()`
+flag and persistence hint (`Command#isPersistHint()`) indicate that it should be.
+
The framework will automatically have set the `completedAt` property of the `Command`.
diff --git a/core/applib/src/main/java/org/apache/isis/applib/services/command/spi/CommandService.java b/core/applib/src/main/java/org/apache/isis/applib/services/command/spi/CommandService.java
index 1fa17fa..ca7d82b 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/services/command/spi/CommandService.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/services/command/spi/CommandService.java
@@ -28,21 +28,12 @@ public interface CommandService {
/**
* Simply instantiate the appropriate instance of the {@link Command}. Its members will be populated automatically
- * by the framework.
+ * by the framework (the {@link Command}'s {@link Command#getTimestamp()}, {@link Command#getUser()} and {@link Command#getTransactionId()}).
*/
@Programmatic
Command create();
/**
- * DEPRECATED - this method is no longer called by the framework.
- *
- * @deprecated - the framework automatically populates the {@link Command}'s {@link Command#getTimestamp()}, {@link Command#getUser()} and {@link Command#getTransactionId()}, so there is no need for the service implementation to initialize any of these. In particular, the {@link Command} will already have been initialized with the provided <tt>transactionId</tt> argument.
- */
- @Deprecated
- @Programmatic
- void startTransaction(final Command command, final UUID transactionId);
-
- /**
* Hint for this implementation to eagerly persist the {@link Command}s if possible; influences the behaviour
* of actions annotated to execute in the {@link org.apache.isis.applib.annotation.CommandExecuteIn#BACKGROUND}.
*/
diff --git a/core/runtime/src/main/java/org/apache/isis/core/runtime/services/command/CommandServiceDefault.java b/core/runtime/src/main/java/org/apache/isis/core/runtime/services/command/CommandServiceDefault.java
index 7d2986a..dbaa0f0 100644
--- a/core/runtime/src/main/java/org/apache/isis/core/runtime/services/command/CommandServiceDefault.java
+++ b/core/runtime/src/main/java/org/apache/isis/core/runtime/services/command/CommandServiceDefault.java
@@ -38,13 +38,6 @@ public class CommandServiceDefault implements CommandService {
return new CommandDefault();
}
- @Deprecated
- @Programmatic
- @Override
- public void startTransaction(final Command command, final UUID transactionId) {
- // nothing to do.
- }
-
@Programmatic
@Override
public void complete(final Command command) {
diff --git a/todo-deprecation-list.txt b/todo-deprecation-list.txt
index 3d71494..ee73ba2 100644
--- a/todo-deprecation-list.txt
+++ b/todo-deprecation-list.txt
@@ -26,26 +26,7 @@ org.apache.isis.applib.services.bookmark (8 usages found)
org.apache.isis.applib.services.classdiscovery
ClassDiscoveryService.java , push down into ClassDiscoveryService2
-org.apache.isis.applib.services.command
- Command2.java - methods for working with interaction events (remove with those event types)
- flushActionInteractionEvents()
- peekActionInteractionEvent()
- popActionInteractionEvent()
- pushActionInteractionEvent(ActionInteractionEvent<?>)
-org.apache.isis.applib.services.command.spi
- CommandService.java
- startTransaction(Command, UUID) - no longer required to do anything, so remove
-
-org.apache.isis.applib.services.eventbus
- AbstractInteractionEvent.java - remove
- ActionInteractionEvent.java - remove
- ActionInvokedEvent.java - remove
- CollectionAddedToEvent.java - remove
- CollectionInteractionEvent.java - remove
- CollectionRemovedFromEvent.java - remove
- PropertyChangedEvent.java - remove
- PropertyInteractionEvent.java - remove
org.apache.isis.applib.services.memento (19 usages found)
MementoService.java - remove entire service (previously to support view models, but now @ViewModel and JAXB)
@@ -432,6 +413,32 @@ org.apache.isis.applib.services.background (10 usages found)
Remove support for legacy persisted commands (beginning "<memento>...")
+org.apache.isis.applib.services.command.spi
+ CommandService.java
+ startTransaction(Command, UUID) - no longer required to do anything, so remove
+
+
+
+
+org.apache.isis.applib.services.command
+ Command2.java - methods for working with interaction events (remove with those event types)
+ flushActionInteractionEvents()
+ peekActionInteractionEvent()
+ popActionInteractionEvent()
+ pushActionInteractionEvent(ActionInteractionEvent<?>)
+
+
+org.apache.isis.applib.services.eventbus
+ AbstractInteractionEvent.java - remove
+ ActionInteractionEvent.java - remove
+ ActionInvokedEvent.java - remove
+ CollectionAddedToEvent.java - remove
+ CollectionInteractionEvent.java - remove
+ CollectionRemovedFromEvent.java - remove
+ PropertyChangedEvent.java - remove
+ PropertyInteractionEvent.java - remove
+
+
org.apache.isis.viewer.restfulobjects.rendering.service.conmap.ContentMappingService
--
To stop receiving notification emails like this one, please contact
['"commits@isis.apache.org" <co...@isis.apache.org>'].