[GitHub] incubator-beam pull request #1058: Fixes a bug in avroio_test.py

[chamikaramj <gi...@git.apache.org>]

GitHub user chamikaramj opened a pull request:

    https://github.com/apache/incubator-beam/pull/1058

    Fixes a bug in avroio_test.py

    Fixes a bug in avroio_test.py where we open a binary file without 'b' mode. Without this, file can get corrupted in Windows and the test becomes flaky.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamikaramj/incubator-beam fix_avro_test_windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1058.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1058
    
----
commit 6ed258e97a3bde460315b5aef1449c38f80dc564
Author: Chamikara Jayalath <ch...@google.com>
Date:   2016-10-05T23:23:09Z

    Fixes a bug in avroio_test.py where we open a binary file without 'b'
    mode. Without this file can get corrupted in Windows and the test becomes flaky.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1058: Fixes a bug in avroio_test.py

[chamikaramj <gi...@git.apache.org>]

Github user chamikaramj closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1058


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---