You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by lr...@apache.org on 2007/05/20 08:44:52 UTC
svn commit: r539834 - in
/incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig:
DBDataHelper.java DBHelper.java
Author: lresende
Date: Sat May 19 23:44:51 2007
New Revision: 539834
URL: http://svn.apache.org/viewvc?view=rev&rev=539834
Log:
Properly closing database connections and statements
Modified:
incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBDataHelper.java
incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBHelper.java
Modified: incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBDataHelper.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBDataHelper.java?view=diff&rev=539834&r1=539833&r2=539834
==============================================================================
--- incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBDataHelper.java (original)
+++ incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBDataHelper.java Sat May 19 23:44:51 2007
@@ -96,6 +96,7 @@
} finally {
try {
dbStatement.close();
+ dbConnection.close();
} catch (SQLException e1) {
// ignore and return false
}
@@ -173,6 +174,7 @@
} finally {
try {
dbStatement.close();
+ dbConnection.close();
} catch (SQLException e1) {
// ignore and return false
}
@@ -208,6 +210,7 @@
} finally {
try {
dbStatement.close();
+ dbConnection.close();
} catch (SQLException e1) {
// ignore and return false
}
Modified: incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBHelper.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBHelper.java?view=diff&rev=539834&r1=539833&r2=539834
==============================================================================
--- incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBHelper.java (original)
+++ incubator/tuscany/java/das/samples/dbconfig/src/main/java/org/apache/tuscany/das/rdb/dbconfig/DBHelper.java Sat May 19 23:44:51 2007
@@ -114,6 +114,7 @@
this.logger.log(Level.DEBUG, "Error retrieving database metadata", e);
} finally {
try {
+ dbStatement.close();
dbConnection.close();
} catch (SQLException e) {
// ignore here
@@ -156,6 +157,7 @@
this.logger.log(Level.DEBUG, "Error droping table", e);
} finally {
try {
+ dbStatement.close();
dbConnection.close();
} catch (SQLException e) {
// ignore here
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org