You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Steve Hay <st...@uk.radan.com> on 2005/01/07 12:57:15 UTC

[PATCH] Re: [ANNOUNCE] mod_perl 1.99_20 (2.0.0-RC3)

Philippe M. Chiasson wrote:

>mod_perl 1.99_20 (2.0.0-RC3) is out:
>  
>
All tests OK on WinXP/VC++ with perl-5.8.5 and apache-2.0.50.

Are the t/perl/ithreads*.t tests going to be reinstated into the distro 
sometime?  The current SVN (rev 124479) still works fine for me with 
these tests in, although I had to fix another code-before-declaration 
error when compiling modperl_cmd.c:

Index: src/modules/perl/modperl_cmd.c
===================================================================
--- src/modules/perl/modperl_cmd.c    (revision 124479)
+++ src/modules/perl/modperl_cmd.c    (working copy)
@@ -256,8 +256,8 @@
 
     if (APR_SUCCESS == apr_stat(&finfo, arg, APR_FINFO_TYPE, p)) {
         if (finfo.filetype != APR_NOFILE) {
+            modperl_require_file_t *require = apr_pcalloc(p, 
sizeof(*require));
             MP_TRACE_d(MP_FUNC, "push PerlPostConfigRequire for %s\n", 
arg);
-            modperl_require_file_t *require = apr_pcalloc(p, 
sizeof(*require));
             require->file = arg;
             require->dcfg = dcfg;
            

>Changes since 1.99_19:
>
>[...]
>speed up the 'perl Makefile.PL' stage [Randy Kobes]:
>
Kudos to Randy for this one!  It seems to make quite a big difference on 
my setup.

- Steve


------------------------------------------------
Radan Computational Ltd.

The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only.  If you have received this message in error or there are any problems, please notify the sender immediately.  The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden.  Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd.  The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.99_20 (2.0.0-RC3)

Posted by Stas Bekman <st...@stason.org>.
Steve Hay wrote:
> Philippe M. Chiasson wrote:
> 
> 
>>mod_perl 1.99_20 (2.0.0-RC3) is out:
>> 
>>
> 
> All tests OK on WinXP/VC++ with perl-5.8.5 and apache-2.0.50.
> 
> Are the t/perl/ithreads*.t tests going to be reinstated into the distro 
> sometime?  

Not any time soon, I still get random failures on linux.

> The current SVN (rev 124479) still works fine for me with 
> these tests in, although I had to fix another code-before-declaration 
> error when compiling modperl_cmd.c:
> 
> Index: src/modules/perl/modperl_cmd.c
> ===================================================================
> --- src/modules/perl/modperl_cmd.c    (revision 124479)
> +++ src/modules/perl/modperl_cmd.c    (working copy)
> @@ -256,8 +256,8 @@
>  
>      if (APR_SUCCESS == apr_stat(&finfo, arg, APR_FINFO_TYPE, p)) {
>          if (finfo.filetype != APR_NOFILE) {
> +            modperl_require_file_t *require = apr_pcalloc(p, 
> sizeof(*require));
>              MP_TRACE_d(MP_FUNC, "push PerlPostConfigRequire for %s\n", 
> arg);
> -            modperl_require_file_t *require = apr_pcalloc(p, 
> sizeof(*require));
>              require->file = arg;
>              require->dcfg = dcfg;

Thanks applied.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org