[GitHub] dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag

[gi...@git.apache.org]

dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag 
URL: https://github.com/apache/incubator-openwhisk/pull/2334#discussion_r124653236
 
 

 ##########
 File path: tests/src/test/scala/common/Wsk.scala
 ##########
 @@ -559,12 +559,16 @@ class WskActivation()
      * if the code is anything but DONTCARE_EXIT, assert the code is as expected
      */
     def get(
-        activationId: String,
+        activationId: Option[String] = None,
         expectedExitCode: Int = SUCCESS_EXIT,
-        fieldFilter: Option[String] = None)(
+        fieldFilter: Option[String] = None,
+        last: Option[Boolean] = None)(
             implicit wp: WskProps): RunResult = {
-        val params = { fieldFilter map { f => Seq(f) } getOrElse Seq() }
-        cli(wp.overrides ++ Seq(noun, "get", "--auth", wp.authKey, activationId) ++ params, expectedExitCode)
+        val params =
+          {activationId map {a => Seq(a)} getOrElse Seq() } ++
 
 Review comment:
   Space after `{` for `activationId` and `last`.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services