You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/04/11 01:55:37 UTC

[GitHub] [netbeans] pepness opened a new pull request, #3954: Update asm from 9.2 to 9.3

pepness opened a new pull request, #3954:
URL: https://github.com/apache/netbeans/pull/3954

   Library Notes:
   - JDK 19 support
   - Bug fixes
     - 317949: fix javadoc errors
     - remap invokedynamic field handles properly
     - add missing left curly brace in ASMifier output of visitModule
   
   Testing:
   - Full build done
   - Verify successful execution of libraries and licenses Ant test
   
   [ASM Web Page](https://asm.ow2.io/index.html)
   [Release Notes](https://asm.ow2.io/versions.html)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] pepness merged pull request #3954: Update asm from 9.2 to 9.3

Posted by GitBox <gi...@apache.org>.
pepness merged PR #3954:
URL: https://github.com/apache/netbeans/pull/3954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #3954: Update asm from 9.2 to 9.3

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #3954:
URL: https://github.com/apache/netbeans/pull/3954#issuecomment-1153261906

   I suggest to merge this - we are early in the NB16 cycle and I think now would be a good time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on a diff in pull request #3954: Update asm from 9.2 to 9.3

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on code in PR #3954:
URL: https://github.com/apache/netbeans/pull/3954#discussion_r853250129


##########
nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps:
##########
@@ -85,9 +85,9 @@ extide/gradle/external/gradle-7.4-bin.zip platform/libs.testng/external/jcommand
 extide/gradle/external/gradle-7.4-bin.zip platform/o.apache.commons.io/external/commons-io-2.6.jar
 extide/gradle/external/gradle-7.4-bin.zip enterprise/cloud.oracle/external/jsr305-3.0.2.jar
 extide/gradle/external/gradle-7.4-bin.zip platform/o.apache.commons.codec/external/commons-codec-1.15.jar
-extide/gradle/external/gradle-7.4-bin.zip platform/libs.asm/external/asm-9.2.jar
-extide/gradle/external/gradle-7.4-bin.zip platform/libs.asm/external/asm-commons-9.2.jar
-extide/gradle/external/gradle-7.4-bin.zip platform/libs.asm/external/asm-tree-9.2.jar
+extide/gradle/external/gradle-7.4-bin.zip platform/libs.asm/external/asm-9.3.jar

Review Comment:
   Well. At the moment Gradle 7.4 comes with asm 0.9.2 so technically these lines could be removed as there would be no clash. On the other hand, it would be fine when newer Gradle would switch to 0.9.3, so I'd prefer to have it this way.
   
   This is just an informational comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists