[jira] [Updated] (THRIFT-4758) We gitignore and do not check in config lock files in many languages - isn't that bad?

["Allen George (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen George updated THRIFT-4758:
---------------------------------
    Component/s:     (was: Rust - Compiler)

> We gitignore and do not check in config lock files in many languages - isn't that bad?
> --------------------------------------------------------------------------------------
>
>                 Key: THRIFT-4758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4758
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process, D - Library, Dart - Library, PHP - Library, Ruby - Library
>    Affects Versions: 0.12.0
>            Reporter: James E. King III
>            Priority: Major
>
> In npm we check in the package-lock.json file because that ensures your builds are stable over time.  The cost you pay is that occasionally you need to rev the file manually.  The benefit is a changed package won't bork your build.
> I have identified in the following languages we are ignoring and not checking in the package lock files:
> d (dub)
> dart
> php (top level composer.jock)
> ruby
> rust



--
This message was sent by Atlassian Jira
(v8.3.4#803005)