You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/18 08:42:12 UTC
[GitHub] [airflow] potiuk opened a new pull request #7200: [AIRFLOW-XXXX]
Increease verbosity of static checks in CI
potiuk opened a new pull request #7200: [AIRFLOW-XXXX] Increease verbosity of static checks in CI
URL: https://github.com/apache/airflow/pull/7200
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
https://github.com/pre-commit/pre-commit/issues/1144 and they
finally implemented it after long time saying "no" :).
This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7200: [AIRFLOW-XXXX] Increease
verbosity of static checks in CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7200: [AIRFLOW-XXXX] Increease verbosity of static checks in CI
URL: https://github.com/apache/airflow/pull/7200#issuecomment-575879333
@tooptoop4 -> here you are.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7200: [AIRFLOW-XXXX]
Increease verbosity of static checks in CI
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7200: [AIRFLOW-XXXX] Increease verbosity of static checks in CI
URL: https://github.com/apache/airflow/pull/7200#issuecomment-575917536
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7200?src=pr&el=h1) Report
> Merging [#7200](https://codecov.io/gh/apache/airflow/pull/7200?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5abce471e0690c6b8d06ca25685b0845c5fd270f?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7200?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7200 +/- ##
==========================================
+ Coverage 85.41% 85.42% +0.01%
==========================================
Files 753 753
Lines 39685 39747 +62
==========================================
+ Hits 33898 33955 +57
- Misses 5787 5792 +5
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7200?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/amazon/aws/sensors/emr\_base.py](https://codecov.io/gh/apache/airflow/pull/7200/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Vtcl9iYXNlLnB5) | `93.61% <0%> (-6.39%)` | :arrow_down: |
| [...rflow/providers/amazon/aws/sensors/emr\_job\_flow.py](https://codecov.io/gh/apache/airflow/pull/7200/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Vtcl9qb2JfZmxvdy5weQ==) | `95% <0%> (-0.46%)` | :arrow_down: |
| [airflow/cli/commands/dag\_command.py](https://codecov.io/gh/apache/airflow/pull/7200/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGFnX2NvbW1hbmQucHk=) | `85.9% <0%> (-0.31%)` | :arrow_down: |
| [airflow/providers/amazon/aws/sensors/emr\_step.py](https://codecov.io/gh/apache/airflow/pull/7200/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Vtcl9zdGVwLnB5) | `100% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7200?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7200?src=pr&el=footer). Last update [5abce47...fa3ee76](https://codecov.io/gh/apache/airflow/pull/7200?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7200: [AIRFLOW-XXXX]
Increease verbosity of static checks in CI
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7200: [AIRFLOW-XXXX] Increease verbosity of static checks in CI
URL: https://github.com/apache/airflow/pull/7200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services