You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/04/19 23:51:44 UTC
Review Request 46411: Removed private header from the balloon
framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46411/
-----------------------------------------------------------
Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
Bugs: MESOS-5174
https://issues.apache.org/jira/browse/MESOS-5174
Repository: mesos
Description
-------
Changes the `statusUpdate` handler to explicitly enumerate terminal
states. Previously, the handler used an internal utility method, which
would not be available if this framework were compiled outside of Mesos.
Diffs
-----
src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3
Diff: https://reviews.apache.org/r/46411/diff/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 46411: Removed private header from the balloon
framework.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46411/#review129964
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 19, 2016, 9:51 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46411/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 9:51 p.m.)
>
>
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changes the `statusUpdate` handler to explicitly enumerate terminal
> states. Previously, the handler used an internal utility method, which
> would not be available if this framework were compiled outside of Mesos.
>
>
> Diffs
> -----
>
> src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3
>
> Diff: https://reviews.apache.org/r/46411/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>