You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2018/06/11 12:53:04 UTC
[GitHub] nifi pull request #2784: NIFI-4508: Update ConsumeAMQP to use basicConsume A...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2784
NIFI-4508: Update ConsumeAMQP to use basicConsume API instead of basicGet in order to provide better performance
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4508
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2784.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2784
----
commit d16105ddd57cea38e9866b6a59fab9d806418a5a
Author: Mark Payne <ma...@...>
Date: 2018-06-08T19:37:17Z
NIFI-4508: Update ConsumeAMQP to use basicConsume API instead of basicGet in order to provide better performance
commit 1c5f07cb43d033ad249136022e30b8dbc9523bbc
Author: Mark Payne <ma...@...>
Date: 2018-06-11T12:48:54Z
NIFI-4508: Added some additional unit tests to verify behavior
----
---
[GitHub] nifi issue #2784: NIFI-4508: Update ConsumeAMQP to use basicConsume API inst...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2784
started looking at this yesterday - looking really good. Will have eval done shortly and check out the added tests. Thanks
---
[GitHub] nifi issue #2784: NIFI-4508: Update ConsumeAMQP to use basicConsume API inst...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2784
The performance improvement is clear. Old way is unable to keep up with its own rate of production while new ways stays in lock step. Have a mirrored flow (just diff versions of amqp processors). Old way can do 2500 messages/sec with new way doing more than double. This is with client-side acks on and testing in as apples to apples a way as possible. The new way can clearly go far faster than 2x the old way.
---
[GitHub] nifi pull request #2784: NIFI-4508: Update ConsumeAMQP to use basicConsume A...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2784
---