You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/15 16:50:15 UTC
[GitHub] [incubator-mxnet] josephevans opened a new pull request #20173: Disable codecov
josephevans opened a new pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173
## Description ##
Disable use of codecov in master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #20173: Disable codecov
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173#issuecomment-820979687
Oh I thought it was the other way around. Nevermind then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20173: Disable codecov
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173#issuecomment-820655365
@marcoabreu safer to have AWS security review first before adding it back. For now we won't support codecov on the CI until it's deemed safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20173: Disable codecov
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173#issuecomment-820774413
Indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20173: Disable codecov
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20173: Disable codecov
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173#issuecomment-820579052
Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, unix-cpu, centos-cpu, clang, edge, sanity, website, windows-cpu, windows-gpu, centos-gpu, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #20173: Disable codecov
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173#issuecomment-820861607
Are you referring to the code from 3 years ago?
https://github.com/apache/incubator-mxnet/blob/ecadeac9a2fbacc7e5b726783ecac6bdc7558b1e/ci/Jenkinsfile_utils.groovy#L126-L128
I'm not sure that would have prevented the problem as it's only fallback :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20173: Disable codecov
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173#issuecomment-820656383
The follow up step is to add the rotated credentials to make the CI work again, have the security team in AWS review whether codecov is acceptably safe on our system, and then add it back afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #20173: Disable codecov
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173#issuecomment-820679265
Okay, works for me . Thanks!
Btw, with the cached version of codecov which we used before, this would have been averted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #20173: Disable codecov
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #20173:
URL: https://github.com/apache/incubator-mxnet/pull/20173#issuecomment-820619992
Could you elaborate? The vulerability already has been patched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org