You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "quantranhong1999 (via GitHub)" <gi...@apache.org> on 2025/04/23 09:45:41 UTC

[PR] JAMES-4077 Relax HTML escaping for highlight result [james-project]

quantranhong1999 opened a new pull request, #2705:
URL: https://github.com/apache/james-project/pull/2705

   Previously, we did HTML escaping for almost all possible characters. cf https://github.com/apache/james-project/pull/2593
   The highlight rendering could be ugly. e.g. the slash `/` character was escaped. `subject": "<mark>Work</mark> from home request (Monday 31&#x2F;03)"`.
   
   Following JMAP SearchSnippet specs (https://jmap.io/spec-mail.html#search-snippets): `&` (ampersand), `<` (less-than sign), and `>` (greater-than sign) characters **MUST** be escaped, while the remaining characters **MAY** depend on server choice.
   
   Let's balance between security and visibility IMO: escape the 3 **MUST** `&` `<` `>` characters, and relax escaping for the rest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-4077 Relax HTML escaping for highlight result [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 closed pull request #2705: JAMES-4077 Relax HTML escaping for highlight result
URL: https://github.com/apache/james-project/pull/2705


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] JAMES-4077 Relax HTML escaping for highlight result [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2705:
URL: https://github.com/apache/james-project/pull/2705#issuecomment-2823829126

   CF https://github.com/linagora/tmail-flutter/issues/3691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org