You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/02/09 18:37:29 UTC
[jira] Created: (CASSANDRA-783) refactor CommitLog
refactor CommitLog
------------------
Key: CASSANDRA-783
URL: https://issues.apache.org/jira/browse/CASSANDRA-783
Project: Cassandra
Issue Type: Task
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 0.6
Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-783) refactor CommitLog
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832278#action_12832278 ]
Jun Rao commented on CASSANDRA-783:
-----------------------------------
The patch looks good to me. Code is cleaner than before.
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSe.patch, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.patch
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-783) refactor CommitLog
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834884#action_12834884 ]
Hudson commented on CASSANDRA-783:
----------------------------------
Integrated in Cassandra #357 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/357/])
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSe.patch, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.patch
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-783:
-------------------------------------
Attachment: 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-783) refactor CommitLog
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831686#action_12831686 ]
Jun Rao commented on CASSANDRA-783:
-----------------------------------
Can't apply 0001 to trunk. Could you rebase?
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-783:
-------------------------------------
Attachment: (was: 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt)
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-783:
-------------------------------------
Attachment: (was: 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt)
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-783:
-------------------------------------
Attachment: (was: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt)
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831658#action_12831658 ]
Jonathan Ellis commented on CASSANDRA-783:
------------------------------------------
02
mv RecoverManager.doRecovery() -> CommitLog.recover()
01
encapsulate commitlog file operations in CommitLogSegment
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-783:
-------------------------------------
Attachment: 0002-mv-RecoverManager.doRecovery-CommitLog.recover.patch
rebased and ran through dos2unix. verified applies to trunk @908652.
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSe.patch, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.patch
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831693#action_12831693 ]
Jonathan Ellis commented on CASSANDRA-783:
------------------------------------------
rebased
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-783:
-------------------------------------
Attachment: 0001-encapsulate-commitlog-file-operations-in-CommitLogSe.patch
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSe.patch, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.patch
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-783) refactor CommitLog
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832147#action_12832147 ]
Jun Rao commented on CASSANDRA-783:
-----------------------------------
still can't apply. Got the following error.
error: patch failed: src/java/org/apache/cassandra/db/commitlog/CommitLogExecutorService.java:11
error: src/java/org/apache/cassandra/db/commitlog/CommitLogExecutorService.java: patch does not apply
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-783:
-------------------------------------
Attachment: 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt, 0002-mv-RecoverManager.doRecovery-CommitLog.recover.txt
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-783) refactor CommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-783:
-------------------------------------
Attachment: (was: 0001-encapsulate-commitlog-file-operations-in-CommitLogSegm.txt)
> refactor CommitLog
> ------------------
>
> Key: CASSANDRA-783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-783
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
>
> Too many global variables. Let's encapsulate the per-file information in CommitLogSegment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.