Re: [PR] [ingestion] Add rate-limited exception logging for transformers [pinot]

["suvodeep-pyne (via GitHub)" <gi...@apache.org>]

suvodeep-pyne commented on code in PR #17239:
URL: https://github.com/apache/pinot/pull/17239#discussion_r2560733161


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java:
##########
@@ -233,7 +237,8 @@ public List<GenericRow> transform(List<GenericRow> records) {
         if (!_continueOnError) {
           throw new RuntimeException("Caught exception while transforming complex types", e);
         }
-        LOGGER.debug("Caught exception while transforming complex types for record: {}", record.toString(), e);
+        _throttledLogger.warn(
+            String.format("Caught exception while transforming complex types for record: %s", record.toString()), e);

Review Comment:
   Removed record logging itself. that address both performance and data risks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org