You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "zhtaoxiang (via GitHub)" <gi...@apache.org> on 2023/06/30 21:35:31 UTC
[GitHub] [pinot] zhtaoxiang opened a new pull request, #11019: update freemaker to fix Server-side Template Injection
zhtaoxiang opened a new pull request, #11019:
URL: https://github.com/apache/pinot/pull/11019
follow the suggestion on https://security.snyk.io/vuln/SNYK-JAVA-ORGFREEMARKER-1076795 to fix Server-side Template Injection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11019: update freemaker to fix Server-side Template Injection
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #11019:
URL: https://github.com/apache/pinot/pull/11019#discussion_r1248581637
##########
contrib/pinot-fmpp-maven-plugin/pom.xml:
##########
@@ -66,6 +66,12 @@
<groupId>net.sourceforge.fmpp</groupId>
<artifactId>fmpp</artifactId>
<version>${fmpp.version}</version>
+ <exclusions>
Review Comment:
Do we need to exclude freemarker here after explicitly specifying its version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #11019: update freemaker to fix Server-side Template Injection
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11019:
URL: https://github.com/apache/pinot/pull/11019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #11019: update freemaker to fix Server-side Template Injection
Posted by "zhtaoxiang (via GitHub)" <gi...@apache.org>.
zhtaoxiang commented on code in PR #11019:
URL: https://github.com/apache/pinot/pull/11019#discussion_r1252438461
##########
contrib/pinot-fmpp-maven-plugin/pom.xml:
##########
@@ -66,6 +66,12 @@
<groupId>net.sourceforge.fmpp</groupId>
<artifactId>fmpp</artifactId>
<version>${fmpp.version}</version>
+ <exclusions>
Review Comment:
yes, otherwise, it reports version conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org