You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/21 16:35:31 UTC
svn commit: r1775493 -
/jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
Author: pmouawad
Date: Wed Dec 21 16:35:31 2016
New Revision: 1775493
URL: http://svn.apache.org/viewvc?rev=1775493&view=rev
Log:
Sonar : Fix code smells
Modified:
jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java?rev=1775493&r1=1775492&r2=1775493&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java Wed Dec 21 16:35:31 2016
@@ -39,25 +39,14 @@ import org.apache.log.Logger;
*/
public class HtmlExtractor extends AbstractScopedTestElement implements PostProcessor, Serializable {
+ private static final long serialVersionUID = 3978073849365558131L;
+
public static final String EXTRACTOR_JSOUP = "JSOUP"; //$NON-NLS-1$
public static final String EXTRACTOR_JODD = "JODD"; //$NON-NLS-1$
- /**
- * Get the possible extractor implementations
- * @return Array containing the names of the possible extractors.
- */
- public static String[] getImplementations(){
- return new String[]{EXTRACTOR_JSOUP,EXTRACTOR_JODD};
- }
-
public static final String DEFAULT_EXTRACTOR = ""; // $NON-NLS-1$
- /**
- *
- */
- private static final long serialVersionUID = 3978073849365558131L;
-
private static final Logger log = LoggingManager.getLoggerForClass();
private static final String EXPRESSION = "HtmlExtractor.expr"; // $NON-NLS-1$
@@ -79,6 +68,15 @@ public class HtmlExtractor extends Abstr
private static final String DEFAULT_EMPTY_VALUE = "HtmlExtractor.default_empty_value"; // $NON-NLS-1$
private Extractor extractor;
+
+ /**
+ * Get the possible extractor implementations
+ * @return Array containing the names of the possible extractors.
+ */
+ public static String[] getImplementations(){
+ return new String[]{EXTRACTOR_JSOUP,EXTRACTOR_JODD};
+ }
+
/**
* Parses the response data using CSS/JQuery expressions and saving the results
@@ -93,7 +91,9 @@ public class HtmlExtractor extends Abstr
if (previousResult == null) {
return;
}
- log.debug("HtmlExtractor "+getName()+":processing result");
+ if(log.isDebugEnabled()) {
+ log.debug("HtmlExtractor "+getName()+":processing result");
+ }
// Fetch some variables
JMeterVariables vars = context.getVariables();
@@ -135,15 +135,15 @@ public class HtmlExtractor extends Abstr
for (int i = 1; i <= matchCount; i++) {
match = getCorrectMatch(matches, i);
if (match != null) {
- final String refName_n = new StringBuilder(refName).append(UNDERSCORE).append(i).toString();
- vars.put(refName_n, match);
+ final String refNameN = new StringBuilder(refName).append(UNDERSCORE).append(i).toString();
+ vars.put(refNameN, match);
}
}
}
// Remove any left-over variables
for (int i = matchCount + 1; i <= prevCount; i++) {
- final String refName_n = new StringBuilder(refName).append(UNDERSCORE).append(i).toString();
- vars.remove(refName_n);
+ final String refNameN = new StringBuilder(refName).append(UNDERSCORE).append(i).toString();
+ vars.remove(refNameN);
}
} catch (RuntimeException e) {
log.warn(getName()+":Error while generating result " + e);