You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/11/05 13:33:44 UTC

[jira] Created: (QPID-1433) BlockingWaiters will drop locks on error notifcation

BlockingWaiters will drop locks on error notifcation
----------------------------------------------------

                 Key: QPID-1433
                 URL: https://issues.apache.org/jira/browse/QPID-1433
             Project: Qpid
          Issue Type: Bug
          Components: Java Client
    Affects Versions: M3, M2.1
            Reporter: Martin Ritchie
            Assignee: Martin Ritchie
            Priority: Critical
             Fix For: M4


Summary:

BlockingWaiter.error() has an incorrect use of lock();

All lock() calls must be immediately followed by a try finally{release()} block.

In the BlockingWaiter case the lock is lost if the BlockingWaiter is closed. L245-248 : If(_closed) return;

It is very unlikely that our BlockingWaiter will receive more than one error but if a closed BlockingWaiter did receive a second error then that second thread would block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (QPID-1433) BlockingWaiters will drop locks on error notifcation

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-1433:
---------------------------------

    Affects Version/s: M4

> BlockingWaiters will drop locks on error notifcation
> ----------------------------------------------------
>
>                 Key: QPID-1433
>                 URL: https://issues.apache.org/jira/browse/QPID-1433
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: M2.1, M3, M4
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Minor
>
> Summary:
> BlockingWaiter.error() has an incorrect use of lock();
> All lock() calls must be immediately followed by a try finally{release()} block.
> In the BlockingWaiter case the lock is lost if the BlockingWaiter is closed. L245-248 : If(_closed) return;
> It is very unlikely that our BlockingWaiter will receive more than one error but if a closed BlockingWaiter did receive a second error then that second thread would block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (QPID-1433) BlockingWaiters will drop locks on error notifcation

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-1433:
---------------------------------

         Priority: Minor  (was: Critical)
    Fix Version/s:     (was: M4)

This is only a theoretical issue and hasn't actually occurred in test or live systems.

> BlockingWaiters will drop locks on error notifcation
> ----------------------------------------------------
>
>                 Key: QPID-1433
>                 URL: https://issues.apache.org/jira/browse/QPID-1433
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: M2.1, M3, M4
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Minor
>
> Summary:
> BlockingWaiter.error() has an incorrect use of lock();
> All lock() calls must be immediately followed by a try finally{release()} block.
> In the BlockingWaiter case the lock is lost if the BlockingWaiter is closed. L245-248 : If(_closed) return;
> It is very unlikely that our BlockingWaiter will receive more than one error but if a closed BlockingWaiter did receive a second error then that second thread would block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (QPID-1433) BlockingWaiters will drop locks on error notifcation

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-1433:
------------------------------------

    Assignee:     (was: Martin Ritchie)

> BlockingWaiters will drop locks on error notifcation
> ----------------------------------------------------
>
>                 Key: QPID-1433
>                 URL: https://issues.apache.org/jira/browse/QPID-1433
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: M2.1, M3, M4
>            Reporter: Martin Ritchie
>            Priority: Minor
>
> Summary:
> BlockingWaiter.error() has an incorrect use of lock();
> All lock() calls must be immediately followed by a try finally{release()} block.
> In the BlockingWaiter case the lock is lost if the BlockingWaiter is closed. L245-248 : If(_closed) return;
> It is very unlikely that our BlockingWaiter will receive more than one error but if a closed BlockingWaiter did receive a second error then that second thread would block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.