You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/04/16 18:35:32 UTC
[GitHub] rafaelweingartner opened a new pull request #2576: Fix Python code
checkstyle execute by "systemvm\test\runtests.sh"
rafaelweingartner opened a new pull request #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh"
URL: https://github.com/apache/cloudstack/pull/2576
## Description
<!--- Describe your changes in detail -->
I noticed a failure in travis for PR #2574 relating to Python code check style. While investigating that error, I found out that when running `cloudstack/systemvm/test/runtests.sh` I was receiving the following errors:
```
[root@AcsBuildVm test]# ./runtests.sh
Running pep8 to check systemvm/python code for errors
../debian/opt/cloud/bin/configure.py:199:33: E126 continuation line over-indented for hanging indent
../debian/opt/cloud/bin/configure.py:207:37: E126 continuation line over-indented for hanging indent
../debian/opt/cloud/bin/configure.py:210:28: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:817:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:818:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:819:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:820:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:821:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:822:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:823:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:827:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:828:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:829:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:830:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:831:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:832:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:833:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:837:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:838:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:839:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:840:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:841:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:842:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:846:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:847:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:848:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:849:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:850:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:851:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:852:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:856:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:857:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:858:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:859:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:860:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:861:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:865:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:866:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:867:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:868:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:869:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:873:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:874:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:875:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:876:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/configure.py:877:17: E121 continuation line indentation is not a multiple of four
../debian/opt/cloud/bin/cs/CsRedundant.py:159:23: E121 continuation line indentation is not a multiple of four
```
That command is executed by Travis. After fixing these issues. The "systemvm\test\runtests.sh" stopped failing.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
Locally
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [X] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
- [ X My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
Testing
- [X] I have added tests to cover my changes.
- [ ] All relevant new and existing integration tests have passed.
- [ ] A full integration testsuite with all test that can run on my environment has passed.
<!-- The following will kick a packaging job, remove if as applicable -->
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services