[GitHub] nishantmonu51 commented on a change in pull request #6792: Integration test for sys tables

[GitBox <gi...@apache.org>]

nishantmonu51 commented on a change in pull request #6792: Integration test for sys tables
URL: https://github.com/apache/incubator-druid/pull/6792#discussion_r244631111
 
 

 ##########
 File path: integration-tests/src/test/resources/queries/sys_segment_queries.json
 ##########
 @@ -0,0 +1,38 @@
+[
+  {
+    "sqlQuery": {
+      "query": "SELECT datasource, count(*) FROM sys.segments GROUP BY 1"
+    },
+    "expectedResults": [
+      {
+        "datasource": "wikipedia_editstream",
+        "EXPR$1": 1
+      },
+      {
+        "datasource": "wikipedia",
+        "EXPR$1": 1
+      },
+      {
+        "datasource": "twitterstream",
+        "EXPR$1": 3
+      }
+    ]
+  },
+  {
+    "sqlQuery": {
+      "query": "SELECT server_type FROM sys.servers"
+    },
+    "expectedResults": [
+      {
+        "server_type": "historical"
+      }
+    ]
+  },
+  {
+    "sqlQuery": {
+      "query": "SELECT * FROM sys.tasks where status='FAILED'"
+    },
+    "expectedResults": [
+    ]
 
 Review comment:
   empty result is not much helpful for validation. 
   It wold be better if we can submit a task and then query for the status of it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org