You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/10/29 13:21:47 UTC
[PR] chore: Remove code for unpacking dictionaries prior to FilterExec [datafusion-comet]
andygrove opened a new pull request, #2659:
URL: https://github.com/apache/datafusion-comet/pull/2659
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Remove code for unpacking dictionaries prior to FilterExec [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on PR #2659:
URL: https://github.com/apache/datafusion-comet/pull/2659#issuecomment-3462451042
> Comet always unpacks dictionaries in ScanExec
Just for me to understand this, is it true for all scan types such as `native_comet`, `native_datafusion`, `native_iceberg_compat`, and maybe `iceberg-rust`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Remove code for unpacking dictionaries prior to FilterExec [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #2659:
URL: https://github.com/apache/datafusion-comet/pull/2659#issuecomment-3462640223
Thanks @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Remove code for unpacking dictionaries prior to FilterExec [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #2659:
URL: https://github.com/apache/datafusion-comet/pull/2659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Remove code for unpacking dictionaries prior to FilterExec [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2659:
URL: https://github.com/apache/datafusion-comet/pull/2659#issuecomment-3461598638
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2659?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 10.85%. Comparing base ([`f09f8af`](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a3169`](https://app.codecov.io/gh/apache/datafusion-comet/commit/83a31692e8cf1474b747beba5317facd7f42c9a9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 644 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2659 +/- ##
=============================================
- Coverage 56.12% 10.85% -45.28%
+ Complexity 976 232 -744
=============================================
Files 119 147 +28
Lines 11743 13739 +1996
Branches 2251 2345 +94
=============================================
- Hits 6591 1491 -5100
- Misses 4012 12073 +8061
+ Partials 1140 175 -965
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/2659?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Remove code for unpacking dictionaries prior to FilterExec [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #2659:
URL: https://github.com/apache/datafusion-comet/pull/2659#issuecomment-3462507774
> > > Comet always unpacks dictionaries in ScanExec
> >
> >
> > Just for me to understand this, is it true for all scan types such as `native_comet`, `native_datafusion`, `native_iceberg_compat`, and maybe `iceberg-rust`?
>
> It is true for the two scans we support today (`native_comet` and `native_iceberg_compat`), because both are hybrid scans where the native plan reads batches from the JVM via `ScanExec`.
>
> If/when we support the new experimental scans, we will need to ensure they unpack dictionary-encoded arrays if they do not already. I am guessing they already do this, since they are based on DataFusion `DataSourceExec`, where `UTF8View` is now preferred over dictionary-encoding, but @mbutrovich can confirm.
I think we started a discussion of having alternatives for UTF8View to be conditionally onboarded
https://github.com/apache/datafusion/issues/16903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Remove code for unpacking dictionaries prior to FilterExec [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #2659:
URL: https://github.com/apache/datafusion-comet/pull/2659#issuecomment-3462492793
> > Comet always unpacks dictionaries in ScanExec
>
> Just for me to understand this, is it true for all scan types such as `native_comet`, `native_datafusion`, `native_iceberg_compat`, and maybe `iceberg-rust`?
It is true for the two scans we support today (`native_comet` and `native_iceberg_compat`), because both are hybrid scans where the native plan reads batches from the JVM via `ScanExec`.
If/when we support the new experimental scans, we will need to ensure they unpack dictionary-encoded arrays if they do not already. I am guessing they already do this, since they are based on DataFusion `DataSourceExec`, where `UTF8View` is now preferred over dictionary-encoding, but @mbutrovich can confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org