[GitHub] [incubator-apisix-dashboard] membphis commented on a change in pull request #251: add manager & docker-compose

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #251:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/251#discussion_r438579768



##########
File path: api/errno/error.go
##########
@@ -0,0 +1,84 @@
+package errno
+
+import (
+	"encoding/json"
+	"fmt"
+)
+
+type Message struct {
+	Code string
+	Msg  string
+}
+
+var (
+	//AA 01 表示api-manager-api

Review comment:
       pls mainly use chinese

##########
File path: api/errno/error.go
##########
@@ -0,0 +1,84 @@
+package errno
+
+import (
+	"encoding/json"
+	"fmt"
+)
+
+type Message struct {
+	Code string
+	Msg  string
+}
+
+var (
+	//AA 01 表示api-manager-api
+	//BB 00 系统b部信息
+	SystemSuccess   = Message{"010000", "success"}
+	SystemError     = Message{"010001", "system error"}
+	BadRequestError = Message{Code: "010002", Msg: "请求格式错误"}
+	NotFoundError   = Message{Code: "010003", Msg: "没有找到资源"}
+
+	//BB 01表示配置信息

Review comment:
       ditoo

##########
File path: api/errno/error.go
##########
@@ -0,0 +1,84 @@
+package errno
+
+import (
+	"encoding/json"
+	"fmt"
+)
+
+type Message struct {
+	Code string
+	Msg  string
+}
+
+var (
+	//AA 01 表示api-manager-api
+	//BB 00 系统b部信息
+	SystemSuccess   = Message{"010000", "success"}
+	SystemError     = Message{"010001", "system error"}
+	BadRequestError = Message{Code: "010002", Msg: "请求格式错误"}
+	NotFoundError   = Message{Code: "010003", Msg: "没有找到资源"}
+
+	//BB 01表示配置信息
+	ConfEnvError      = Message{"010101", "找不到环境变量: %s"}
+	ConfFilePathError = Message{"010102", "加载配置文件出错: %s"}
+
+	// BB 02 路由模块
+	RouteRequestError      = Message{"010201", "路由请求参数有异常: %s"}
+	ApisixRouteCreateError = Message{"010202", "创建APISIX路由失败: %s"}
+	DBRouteCreateError     = Message{"010203", "路由入库失败: %s"}
+	ApisixRouteUpdateError = Message{"010204", "更新APISIX路由失败: %s"}
+	ApisixRouteDeleteError = Message{"010205", "删除APISIX路由失败: %s"}
+	DBRouteUpdateError     = Message{"010206", "路由更新失败: %s"}
+	DBRouteDeleteError     = Message{"010207", "路由删除失败: %s"}
+
+	// 03 插件模块
+	ApisixPluginListError   = Message{"010301", "查询APISIX插件列表失败: %s"}
+	ApisixPluginSchemaError = Message{"010301", "查询APISIX插件schema失败: %s"}
+)
+
+type Api7Error struct {

Review comment:
       `ApisixError` ?

##########
File path: api/script/db/tables.sql
##########
@@ -0,0 +1,31 @@
+-- route

Review comment:
       need a doc about how to use it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org