You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/20 03:32:33 UTC

[GitHub] [doris] xiaojunjie opened a new pull request, #13504: [bugfix](VecDateTimeValue) eat the value of microsecond in function from_date_format_str

xiaojunjie opened a new pull request, #13504:
URL: https://github.com/apache/doris/pull/13504

   # Proposed changes
   
   Issue Number: none
   
   ## Problem summary
   
   **case**: select str_to_date("2022-05-24 10:00:00.123 PM", "%Y-%m-%d %h:%i:%s.%f %p");
   
   1. disable_vectorized
   Expected: 2022-05-24 22:00:00.123000
   Actual: 2022-05-24 22:00:00.123000
   
   2. enables_vectorized
   Expected: 2022-05-24 22:00:00
   Actual: null
   
   In function **VecDateTimeValue::from_date_format_str**, it is necessary to eat the microsecond "**123**" before parsing "**PM**", even though _microsecond has been removed in class VecDateTimeValue.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [x] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei commented on pull request #13504: [bugfix](VecDateTimeValue) eat the value of microsecond in function from_date_format_str

Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #13504:
URL: https://github.com/apache/doris/pull/13504#issuecomment-1285232353

   https://github.com/apache/doris/pull/13446


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #13504: [bugfix](VecDateTimeValue) eat the value of microsecond in function from_date_format_str

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13504:
URL: https://github.com/apache/doris/pull/13504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org