You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/09 16:30:32 UTC
[GitHub] [netbeans] sdedic opened a new pull request #3741: Support for dark themes for VSCode
sdedic opened a new pull request #3741:
URL: https://github.com/apache/netbeans/pull/3741
NetBeans respects 'darkness' of selected L&F, in particular by diverting images to their `_dark` variants. VScode themes are 'light' and 'dark' as well, so we could reuse the NBLS feature. This PR passes some dark-style L&F parameter to NBLS if vscode itself is using a dark theme - and eventually restarts NBLS if the theme changes from dark to light.
During the implementation I've realized that `--laf` commandline parameter does not actually work for LaFs distributed as modules: LaF class is loaded too early, from bootstrap class loader, so it is not really possible to load Nimbus or FlatLaf. So the commit to NB startup module fixes that - load of the LaF class is retried after module classloader becomes ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #3741: Support for dark themes for VSCode
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #3741:
URL: https://github.com/apache/netbeans/pull/3741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists