You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/07/31 21:21:07 UTC

Re: Review Request 61110: Added name flag to balloon and disk full frameworks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61110/
-----------------------------------------------------------

(Updated July 31, 2017, 9:21 p.m.)


Review request for mesos, Alexander Rukletsov and Alexander Rojas.


Changes
-------

Included /r/61134.


Summary (updated)
-----------------

Added name flag to balloon and disk full frameworks.


Bugs: MESOS-7814
    https://issues.apache.org/jira/browse/MESOS-7814


Repository: mesos


Description
-------

Allows to distinguish the framework between different instances.


Diffs (updated)
-----

  src/examples/balloon_framework.cpp b8c8e387bd8592bc1d27ff62fa9fd5397ad71fb9 
  src/examples/disk_full_framework.cpp 215b6d29cf5f52973f2b211e9fc72ca6ec2afa7a 


Diff: https://reviews.apache.org/r/61110/diff/4/

Changes: https://reviews.apache.org/r/61110/diff/3-4/


Testing
-------

$ make check


Thanks,

Armand Grillet


Re: Review Request 61110: Added name flag to balloon and disk full frameworks.

Posted by Benno Evers <be...@yandex-team.ru>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61110/#review182392
-----------------------------------------------------------


Ship it!




- Benno Evers


On Aug. 1, 2017, 10:20 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61110/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 10:20 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-7814
>     https://issues.apache.org/jira/browse/MESOS-7814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allows to distinguish the framework between different instances.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp dfd049b860345adc33c3e774dcdff0320da107f6 
>   src/examples/disk_full_framework.cpp 215b6d29cf5f52973f2b211e9fc72ca6ec2afa7a 
> 
> 
> Diff: https://reviews.apache.org/r/61110/diff/5/
> 
> 
> Testing
> -------
> 
> $ make check
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Re: Review Request 61110: Added name flag to balloon and disk full frameworks.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61110/#review182592
-----------------------------------------------------------


Ship it!




- Alexander Rukletsov


On Aug. 1, 2017, 10:20 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61110/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 10:20 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-7814
>     https://issues.apache.org/jira/browse/MESOS-7814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allows to distinguish the framework between different instances.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp dfd049b860345adc33c3e774dcdff0320da107f6 
>   src/examples/disk_full_framework.cpp 215b6d29cf5f52973f2b211e9fc72ca6ec2afa7a 
> 
> 
> Diff: https://reviews.apache.org/r/61110/diff/5/
> 
> 
> Testing
> -------
> 
> $ make check
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Re: Review Request 61110: Added name flag to balloon and disk full frameworks.

Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61110/
-----------------------------------------------------------

(Updated Aug. 1, 2017, 10:20 a.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Bugs: MESOS-7814
    https://issues.apache.org/jira/browse/MESOS-7814


Repository: mesos


Description
-------

Allows to distinguish the framework between different instances.


Diffs
-----

  src/examples/balloon_framework.cpp b8c8e387bd8592bc1d27ff62fa9fd5397ad71fb9 
  src/examples/disk_full_framework.cpp 215b6d29cf5f52973f2b211e9fc72ca6ec2afa7a 


Diff: https://reviews.apache.org/r/61110/diff/4/


Testing
-------

$ make check


Thanks,

Armand Grillet