You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/30 09:43:46 UTC

[GitHub] [shardingsphere] JiekerTime commented on a diff in pull request #20651: Add `CREATE DB_DISCOVERY TYPE` docs.

JiekerTime commented on code in PR #20651:
URL: https://github.com/apache/shardingsphere/pull/20651#discussion_r958257471


##########
docs/document/content/reference/distsql/syntax/rdl/rule-definition/db-discovery/create-db-discovery-type.cn.md:
##########
@@ -0,0 +1,46 @@
++++
+title = "CREATE DB_DISCOVERY TYPE"
+weight = 3
++++
+
+## 描述
+
+`CREATE DB_DISCOVERY TYPE` 语法用于创建数据库发现类型规则
+
+### 语法定义
+
+```sql
+CreateDatabaseDiscoveryType ::=
+  'CREATE' 'DB_DISCOVERY' 'TYPE' databaseDiscoveryTypeDefinition ( ',' databaseDiscoveryTypeDefinition )*
+
+databaseDiscoveryTypeDefinition ::=
+    discoveryTypeName '(' 'TYPE' '(' 'NAME' '=' typeName ( ',' 'PROPERTIES' '(' 'key' '=' 'value' ( ',' 'key' '=' 'value' )* ')' )? ')' ')'
+    
+discoveryTypeName ::=
+  identifier
+
+typeName ::=
+  identifier

Review Comment:
   > Hi, `identifier` is not up to date, the latest definition is `string`.
   
   Okay, I got it. I want to handle this in a uniform way after this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org