You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/19 14:17:55 UTC

[GitHub] [cloudstack] sbrueseke opened a new issue, #7115: Unable to deploy VM using Template and custom disk offering

sbrueseke opened a new issue, #7115:
URL: https://github.com/apache/cloudstack/issues/7115

   <!--
   Verify first that your issue/request is not already reported on GitHub.
   Also test if the latest release and main branch are affected too.
   Always add information AFTER of these HTML comments, but no need to delete the comments.
   -->
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Bug Report
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   VM
   ~~~
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on main branch.
   -->
   
   ~~~
   4.17.2.0
   ~~~
   
   ##### CONFIGURATION
   <!--
   Information about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise
   -->
   hypervisor: xcp-ng, advanced networking
   
   ##### OS / ENVIRONMENT
   <!--
   Information about the environment if relevant, N/A otherwise
   -->
   
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   Unable to deploy VM using Template and custom disk offering, fails with error "VM Creation failed. Volume size: -1GB is out of allowed range. Max: 1024 Min:1". This issue is similar to this issue which for ISO: https://github.com/apache/cloudstack/issues/6440 but not the same.
   
   ##### STEPS TO REPRODUCE
   <!--
   For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
   
   For new features, show how the feature would be used.
   -->
   1) Add a new Disk Offering with customized = true
   `/client/api/?isMirrored=false&name=Test+Custom+Disk+Offering&displaytext=Test+Custom+Disk+Offering&storageType=shared&cacheMode=none&provisioningType=thin&customized=true&disksizestrictness=false&command=createDiskOffering&response=json
   `
   2) Create a new Compute Offering with diskofferingstrictness=true (please be aware that in 4.17.2.0 there is a bug and you cannot do this via UI. There is a button for this, but it is broken. This has already being fixed https://github.com/apache/cloudstack/pull/7072) You need to add the disk offering uuid in this api call!
   `/client/api/?issystem=false&name=Test+Compute+Offering&displaytext=Test+Compute+Offering&customized=false&offerha=false&limitcpuuse=false&dynamicscalingenabled=false&diskofferingid=<uuid>&cpunumber=1&cpuspeed=500&memory=512&command=createServiceOffering&diskofferingstrictness=true&response=json`
   
   3) Go to the instance wizard in the UI and choose the just created Compute offering. Do not click anything else and go straight to “Launch instance”.
   
   
   <!-- You can also paste gist.github.com links for larger files -->
   
   ##### EXPECTED RESULTS
   <!-- What did you expect to happen when running the steps above? -->
   
   UI needs to pass parameter rootdisksize with a default value in header of api call deployVirtualMachine even if "Override root disk size" in Template/ISO section is disabled. I do not know where do get this default value from.
   
   ##### ACTUAL RESULTS
   <!-- What actually happened? -->
   
   <!-- Paste verbatim command output between quotes below -->
   
   UI is not passing parameter rootdisksize via header when using api call deployVirtualMachine and "Override root disk size" in Template/ISO section is disabled. When enabling "Override root disk size" in Template/ISO section a default value of 10 is inserted into the wizard and it works.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7115:
URL: https://github.com/apache/cloudstack/issues/7115#issuecomment-1693026682

   marked this as a minor issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7115:
URL: https://github.com/apache/cloudstack/issues/7115#issuecomment-1433291337

   @sbrueseke yes, it makes sense.
   I think it should be obliged to set the root disk size when disk offering is dynamic and strictness is true.
   
   a UI bug
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7115:
URL: https://github.com/apache/cloudstack/issues/7115#issuecomment-1433307474

   > @weizhouapache yes, it should be, but which is the default value to put into the wizard? The size of the template?
   
   yes @sbrueseke 
   If vm is created from ISO, the default might be 1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7115:
URL: https://github.com/apache/cloudstack/issues/7115#issuecomment-1695137307

   fixed by #7913 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sbrueseke commented on issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by GitBox <gi...@apache.org>.
sbrueseke commented on issue #7115:
URL: https://github.com/apache/cloudstack/issues/7115#issuecomment-1398086435

   A question in my opinion is if a custom disk offering should have a default or minimum size value attached to it. I am nit sure where the value of 10 is coming from, but I suppose from the used template parameters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sbrueseke commented on issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by "sbrueseke (via GitHub)" <gi...@apache.org>.
sbrueseke commented on issue #7115:
URL: https://github.com/apache/cloudstack/issues/7115#issuecomment-1433286928

   @weizhouapache does it make sense to add the default template size to the api call if another value is not provided?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7115:
URL: https://github.com/apache/cloudstack/issues/7115#issuecomment-1433269419

   @sbrueseke 
   I can reproduce the issue on UI.
   
   The default value of root disk size comes from the virtual size (not physical size) of vm template. see example below
   ```
   (localcloud) 🐱 > list templates templatefilter=all filter=size,physicalsize
   {
     "count": 4,
     "template": [
       {
         "physicalsize": 461307904,
         "size": 5242880000
       },
       {
         "physicalsize": 43646976,
         "size": 52428800
       },
       {
         "physicalsize": 453181440,
         "size": 4194304000
       },
       {
         "physicalsize": 1769537536,
         "size": 8589934592
       }
     ]
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sbrueseke commented on issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by "sbrueseke (via GitHub)" <gi...@apache.org>.
sbrueseke commented on issue #7115:
URL: https://github.com/apache/cloudstack/issues/7115#issuecomment-1433298365

   @weizhouapache yes, it should be, but which is the default value to put into the wizard? The size of the template?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7115:
URL: https://github.com/apache/cloudstack/issues/7115#issuecomment-1689489774

   fyi, the workaround is as below
   ![image](https://github.com/apache/cloudstack/assets/57355700/3cccaafa-3c19-4ada-bb52-aeba62749339)
   check "Override root disk size" , then it works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache closed issue #7115: Unable to deploy VM using Template and custom disk offering

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache closed issue #7115: Unable to deploy VM using Template and custom disk offering
URL: https://github.com/apache/cloudstack/issues/7115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org