[GitHub] [ozone] adoroszlai commented on pull request #4273: HDDS-7905. [Snapshot] Snapdiff should only return modifications done to the bucket.

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on PR #4273:
URL: https://github.com/apache/ozone/pull/4273#issuecomment-1453889436

   > Another change done here is to move the Managed RocksDB Classes from hadoop-hdds/framework to hadoop-hdds/common as while trying to use the Managed Classes in the Differ module, it complained of not having a dependency on hadoop-hdds/framework but inturn hadoop-hdds/framework has its dependency causing circular dependency , so had to move it to the common module to solve this.
   
   It also adds RocksDB to clients.  `rocksdbjni-7.7.3.jar` is 56MB, which then gets bundled in the FS jars:
   
   Before:
   
   ```
   60M share/ozone/lib/ozone-filesystem-hadoop3-1.4.0-SNAPSHOT.jar
   ```
   
   After:
   
   ```
   115M share/ozone/lib/ozone-filesystem-hadoop3-1.4.0-SNAPSHOT.jar
   ```
   
   Please create a separate module for RocksDB-related stuff, and make `hdds-framework` and `rocksdb-checkpoint-differ` both depend on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org