You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Weijun-H (via GitHub)" <gi...@apache.org> on 2023/02/24 18:41:39 UTC
[GitHub] [arrow-rs] Weijun-H opened a new pull request, #3759: into_inner() for CSV Writer
Weijun-H opened a new pull request, #3759:
URL: https://github.com/apache/arrow-rs/pull/3759
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #520
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3759: into_inner() for CSV Writer
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3759:
URL: https://github.com/apache/arrow-rs/pull/3759#discussion_r1117954790
##########
arrow-csv/src/writer.rs:
##########
@@ -185,6 +185,11 @@ impl<W: Write> Writer<W> {
Ok(())
}
+
+ /// Unwraps this `Writer<W>`, returning the underlying writer
+ pub fn into_inner(self) -> W {
+ self.writer.into_inner().unwrap()
Review Comment:
Perhaps a comment here saying the unwrap is fine because write always flushes, assuming that is actually the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3759: into_inner() for CSV Writer
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3759:
URL: https://github.com/apache/arrow-rs/pull/3759#discussion_r1117961939
##########
arrow-csv/src/writer.rs:
##########
@@ -185,6 +185,11 @@ impl<W: Write> Writer<W> {
Ok(())
}
+
+ /// Unwraps this `Writer<W>`, returning the underlying writer
+ pub fn into_inner(self) -> W {
+ self.writer.into_inner().unwrap()
Review Comment:
I meant an inline comment, not a doc comment, no need to document this for outside consumers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Weijun-H commented on a diff in pull request #3759: into_inner() for CSV Writer
Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on code in PR #3759:
URL: https://github.com/apache/arrow-rs/pull/3759#discussion_r1117955941
##########
arrow-csv/src/writer.rs:
##########
@@ -185,6 +185,11 @@ impl<W: Write> Writer<W> {
Ok(())
}
+
+ /// Unwraps this `Writer<W>`, returning the underlying writer
+ pub fn into_inner(self) -> W {
+ self.writer.into_inner().unwrap()
Review Comment:
It make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3759: into_inner() for CSV Writer
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #3759:
URL: https://github.com/apache/arrow-rs/pull/3759#issuecomment-1445215255
Benchmark runs are scheduled for baseline = d016403001e418098b48051f1abbff09acbf4c8d and contender = 96791ea47b032ce2ebcb07087d3b3007ea0df536. 96791ea47b032ce2ebcb07087d3b3007ea0df536 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c7769cf80ee74f36b81a6c41e3c5234e...9b6675961f1d4c9b915fcdad6c5440f1/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9b447c515a0243f78e2814e3070ef81b...6e5013740e894d3ba14818b4d0237ae2/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e980fac73d12489881295bd9c6430319...484ca48dfb3c4e1f8a4cfe63809aa84b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/deff9bbb963849129eaf77e4006f979e...a2e29724050f4629871ac148e66c1264/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3759: into_inner() for CSV Writer
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3759:
URL: https://github.com/apache/arrow-rs/pull/3759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org