You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/03/03 00:15:44 UTC
[kudu-CR] Replace ASSERT STATUS OK with ASSERT OK
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9475
to review the following change.
Change subject: Replace ASSERT_STATUS_OK with ASSERT_OK
......................................................................
Replace ASSERT_STATUS_OK with ASSERT_OK
Used the following command line:
for f in $(git grep -l ASSERT_STATUS_OK) do
sed -i s/ASSERT_STATUS_OK/ASSERT_OK/g $f
done
ASSERT_STATUS_OK_FAST comes along for the ride.
Change-Id: I4327f87fb98b186a8f83cf211c38fbddd08c3b05
---
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/compression-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/row_changelist-test.cc
M src/kudu/common/row_operations-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log_anchor_registry-test.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/master-test-util.h
M src/kudu/master/master-test.cc
M src/kudu/master/sys_catalog-test.cc
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/logical_clock-test.cc
M src/kudu/server/webserver-test.cc
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction_policy-test.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/delta_compaction-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/mt-diskrowset-test.cc
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_peer-test.cc
M src/kudu/tserver/remote_bootstrap_service-test.cc
M src/kudu/tserver/remote_bootstrap_session-test.cc
M src/kudu/tserver/tablet_server-stress-test.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/twitter-demo/parser-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/failure_detector-test.cc
M src/kudu/util/memenv/memenv-test.cc
M src/kudu/util/metrics-test.cc
M src/kudu/util/mt-metrics-test.cc
M src/kudu/util/net/dns_resolver-test.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/os-util-test.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/pstack_watcher-test.cc
M src/kudu/util/resettable_heartbeater-test.cc
M src/kudu/util/subprocess-test.cc
M src/kudu/util/sync_point-test.cc
M src/kudu/util/test_macros.h
M src/kudu/util/thread-test.cc
M src/kudu/util/threadpool-test.cc
M src/kudu/util/user-test.cc
86 files changed, 1,236 insertions(+), 1,242 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/9475/1
--
To view, visit http://gerrit.cloudera.org:8080/9475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4327f87fb98b186a8f83cf211c38fbddd08c3b05
Gerrit-Change-Number: 9475
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Replace ASSERT STATUS OK with ASSERT OK
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/9475 )
Change subject: Replace ASSERT_STATUS_OK with ASSERT_OK
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/9475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4327f87fb98b186a8f83cf211c38fbddd08c3b05
Gerrit-Change-Number: 9475
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>