You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2015/02/24 20:00:14 UTC
[Bug 57632] New: mod_systemd passes invalid default to APACHE_MODULE
https://bz.apache.org/bugzilla/show_bug.cgi?id=57632
Bug ID: 57632
Summary: mod_systemd passes invalid default to APACHE_MODULE
Product: Apache httpd-2
Version: 2.5-HEAD
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Other Modules
Assignee: bugs@httpd.apache.org
Reporter: pterjan@linuxfr.org
Created attachment 32519
--> https://bz.apache.org/bugzilla/attachment.cgi?id=32519&action=edit
Change the default to something that seems valid
It passes "all" which is not valid if you read acinclude.m4.
This patch changes it to the undocumented maybe-all which seems to be the
closest one to what I imagine "all" would mean.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 57632] mod_systemd passes invalid default to APACHE_MODULE
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57632
Joe Orton <jo...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #3 from Joe Orton <jo...@redhat.com> ---
I changed it to "no" in r1872763 so it's disabled by default for "all", which
makes more sense to me since it does change behaviour if loaded.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 57632] mod_systemd passes invalid default to APACHE_MODULE
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57632
Pascal Terjan <pt...@linuxfr.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 57632] mod_systemd passes invalid default to APACHE_MODULE
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57632
--- Comment #2 from Pascal Terjan <pt...@linuxfr.org> ---
Anything other than "yes|static|shared" will have the wanted effect of setting
_apmod_required="no", but "all" is not an expected value.
Other expected values are:
- "most" which only tries to enable it if "most", "all" or "reallyall" modules
are requested
- "maybe-all" which only tries to enable it if "all" or "reallyall" modules are
requested
- "no" which only tries to enable it if "reallyall" modules are requested
Everything else is not explicitely handled andjust going through the != "no".
This means in particular that it is not set to $module_default (static or
shared) but always shared.
"maybe-all" is actually what is used if an empty argument is passed, and means
"disabled under default, most. enabled explicitly or with all."
So this patch causes a change as it will not be enabled if people request
"none", "few"or "most" modules while it currently is (which seems wrong for
"none" and "few").
Changing it to "most" or "" may be better but current value is wrong.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 57632] mod_systemd passes invalid default to APACHE_MODULE
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57632
--- Comment #1 from Eric Covener <co...@gmail.com> ---
This seems to have been the rationale:
http://svn.apache.org/viewvc?view=revision&revision=1396440
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org