You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/10 15:09:53 UTC

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1418: Fix DeltaBitPack MiniBlock Bit Width Padding

tustvold commented on a change in pull request #1418:
URL: https://github.com/apache/arrow-rs/pull/1418#discussion_r823822808



##########
File path: parquet/src/encodings/decoding.rs
##########
@@ -668,9 +667,9 @@ where
 
             read += batch_read;
             self.mini_block_remaining -= batch_read;
+            self.values_left -= batch_read;

Review comment:
       This is the fix for #1417 - the problem was that as `self.value_left` was only decremented outside the loop, the code in `next_block` was unable to correctly determine when the bit widths were padding




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org