You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/19 01:11:34 UTC
[GitHub] [druid] gianm opened a new pull request #11956: PrioritizedExecutorService: Properly wrap on direct calls to "execute".
gianm opened a new pull request #11956:
URL: https://github.com/apache/druid/pull/11956
Usually, "execute" is called by methods defined in the superclass
AbstractExecutorService, and the passed-in Runnable has been wrapped
by newTaskFor inside a PrioritizedListenableFutureTask. But this method
can also be called directly, and if so, the same wrapping is necessary
for the delegate to get a Runnable that can be entered into a priority
queue with the others.
I don't think this affects production, because I didn't find any production
code that calls this method. I noticed it while working on another branch
doing something that _did_ end up calling this method on a
PrioritizedExecutorService, so I thought it would be nice to split the fix
into its own patch and test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #11956: PrioritizedExecutorService: Properly wrap on direct calls to "execute".
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #11956:
URL: https://github.com/apache/druid/pull/11956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org