You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2021/03/24 19:23:14 UTC
[cloudstack] branch 4.15 updated: kvm: Do not set backing file
format of DATADISK in vm start/migration (#4800)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.15 by this push:
new 952b242 kvm: Do not set backing file format of DATADISK in vm start/migration (#4800)
952b242 is described below
commit 952b242722c9fb2de26ea4e3777da4aa13ae7961
Author: Wei Zhou <w....@global.leaseweb.com>
AuthorDate: Wed Mar 24 20:22:51 2021 +0100
kvm: Do not set backing file format of DATADISK in vm start/migration (#4800)
* kvm: Do not rebase DATADISK in vm start/migration
* #4800: add comment and use isBlank
---
.../com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index 4cb356c..275d395 100644
--- a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -4266,7 +4266,11 @@ public class LibvirtComputingResource extends ServerResourceBase implements Serv
Map<String, String> info = qemu.info(file);
String backingFilePath = info.get(new String("backing_file"));
String backingFileFormat = info.get(new String("backing_file_format"));
- if (org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
+ if (org.apache.commons.lang.StringUtils.isNotBlank(backingFilePath)
+ && org.apache.commons.lang.StringUtils.isBlank(backingFileFormat)) {
+ // VMs which are created in CloudStack 4.14 and before cannot be started or migrated
+ // in latest Linux distributions due to missing backing file format
+ // Please refer to https://libvirt.org/kbase/backing_chains.html#vm-refuses-to-start-due-to-misconfigured-backing-store-format
s_logger.info("Setting backing file format of " + volPath);
QemuImgFile backingFile = new QemuImgFile(backingFilePath);
Map<String, String> backingFileinfo = qemu.info(backingFile);