You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/17 14:33:48 UTC
[GitHub] [apisix-ingress-controller] cmssczy opened a new pull request #875: update the-hard-way.md
cmssczy opened a new pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
some infomation is outdated in the-hard-way.md
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] cmssczy commented on a change in pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
cmssczy commented on a change in pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875#discussion_r809690881
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -127,6 +127,10 @@ spec:
volumeMounts:
- name: data
mountPath: /etcd
+ # If you don't have a storage provisioner or don't want to use persistence volume, you could use an `emptyDir` as follow.
+ # volumes:
+ # - name: data
+ # emptyDir: {}
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875#discussion_r809645091
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -127,6 +127,10 @@ spec:
volumeMounts:
- name: data
mountPath: /etcd
+ # If you don't have a storage provisioner or don't want to use persistence volume, you could use an `emptyDir` as follow.
+ # volumes:
+ # - name: data
+ # emptyDir: {}
Review comment:
need remove space :joy_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875#issuecomment-1047343199
ping @lingsamuel @tokers @gxthrj for review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] cmssczy commented on a change in pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
cmssczy commented on a change in pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875#discussion_r812521229
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -443,11 +447,13 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: apisix-ingress-controller
+ namespace: apisix
Review comment:
This doc tells us to install apisix-ingress-controller manually but not by helm. And all the configurations are all deployed in `apisix` namespace, deployment/serviceAccount/clusterRole, etc. So I think we should specify this parameter explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875#discussion_r809155778
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -730,21 +737,22 @@ After the ingress controller status is converted to `Running`, we could create a
Here is an example ApisixRoute:
```yaml
-apiVersion: apisix.apache.org/v2beta1
+apiVersion: apisix.apache.org/v2beta3
kind: ApisixRoute
metadata:
name: httpserver-route
+ namespace: demo
spec:
http:
- - name: httpbin
- match:
- hosts:
- - local.httpbin.org
- paths:
- - "/*"
- backend:
- serviceName: httpbin
- servicePort: 80
+ - name: httpbin
+ match:
+ hosts:
+ - local.httpbin.org
+ paths:
+ - /*
+ backends:
+ - serviceName: httpbin
+ servicePort: 80
Review comment:
remove a space
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -730,21 +737,22 @@ After the ingress controller status is converted to `Running`, we could create a
Here is an example ApisixRoute:
```yaml
-apiVersion: apisix.apache.org/v2beta1
+apiVersion: apisix.apache.org/v2beta3
kind: ApisixRoute
metadata:
name: httpserver-route
+ namespace: demo
spec:
http:
- - name: httpbin
- match:
- hosts:
- - local.httpbin.org
- paths:
- - "/*"
- backend:
- serviceName: httpbin
- servicePort: 80
+ - name: httpbin
+ match:
+ hosts:
+ - local.httpbin.org
+ paths:
+ - /*
+ backends:
+ - serviceName: httpbin
+ servicePort: 80
Review comment:
```suggestion
backends:
- serviceName: httpbin
servicePort: 80
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875#discussion_r809643700
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -127,6 +127,10 @@ spec:
volumeMounts:
- name: data
mountPath: /etcd
+ # If you don't have a storage provisioner or don't want to use persistence volume, you could use an `emptyDir` as follow.
+ # volumes:
+ # - name: data
+ # emptyDir: {}
Review comment:
```suggestion
# emptyDir: {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] cmssczy commented on a change in pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
cmssczy commented on a change in pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875#discussion_r809601184
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -730,21 +737,22 @@ After the ingress controller status is converted to `Running`, we could create a
Here is an example ApisixRoute:
```yaml
-apiVersion: apisix.apache.org/v2beta1
+apiVersion: apisix.apache.org/v2beta3
kind: ApisixRoute
metadata:
name: httpserver-route
+ namespace: demo
spec:
http:
- - name: httpbin
- match:
- hosts:
- - local.httpbin.org
- paths:
- - "/*"
- backend:
- serviceName: httpbin
- servicePort: 80
+ - name: httpbin
+ match:
+ hosts:
+ - local.httpbin.org
+ paths:
+ - /*
+ backends:
+ - serviceName: httpbin
+ servicePort: 80
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on a change in pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on a change in pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875#discussion_r811790112
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -443,11 +447,13 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: apisix-ingress-controller
+ namespace: apisix
Review comment:
Do we need to hardcode the namespace? It is already configured in the command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #875: update the-hard-way.md
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #875:
URL: https://github.com/apache/apisix-ingress-controller/pull/875#discussion_r812546325
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -443,11 +447,13 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: apisix-ingress-controller
+ namespace: apisix
Review comment:
I agree, we can keep them consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org