You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/09/17 05:27:27 UTC

[GitHub] [carbondata] kunal642 commented on a change in pull request #4218: [CARBONDATA-4285] Fix alter add complex columns with global sort compaction failure

kunal642 commented on a change in pull request #4218:
URL: https://github.com/apache/carbondata/pull/4218#discussion_r710760760



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessorStepOnSpark.scala
##########
@@ -219,6 +219,7 @@ object DataLoadProcessorStepOnSpark {
       rows: Iterator[CarbonRow],
       index: Int,
       modelBroadcast: Broadcast[CarbonLoadModel],
+      isCompactionFlow: Boolean = false,

Review comment:
       why add this in between? if you keep in last then scala will take the default value if not passed, so change in DataLoadProcessBuilderOnSpark.scala will not be required 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org