[GitHub] [superset] villebro commented on a change in pull request #17587: chore(explore): Migrate BigNumber to v1 api [ID-28][ID-55]

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #17587:
URL: https://github.com/apache/superset/pull/17587#discussion_r767162843



##########
File path: superset-frontend/packages/superset-ui-core/src/query/types/QueryResponse.ts
##########
@@ -76,6 +76,8 @@ export interface ChartDataResponseResult {
     | 'scheduled'
     | 'success'
     | 'timed_out';
+  from_dttm: number | null;
+  to_dttm: number | null;

Review comment:
       It appears the `ChartDataResponseResult` schema is pretty badly out of sync with this. For example, the following appear to be missing or have an incorrect name:
   - here we have `cache_dttm`, on `ChartDataResponseResult` we have `cached_dttm`
   - `colnames` and `coltypes` are missing on `ChartDataResponseResult`.
   - `from_dttm` and `to_dttm` should also be added to `ChartDataResponseResult`.
   Let's try to make sure these are in sync.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org