You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by bo...@apache.org on 2012/08/16 16:23:29 UTC
svn commit: r1373859 - in
/hadoop/common/trunk/hadoop-common-project/hadoop-common: CHANGES.txt
src/main/java/org/apache/hadoop/util/LineReader.java
src/test/java/org/apache/hadoop/util/TestLineReader.java
Author: bobby
Date: Thu Aug 16 14:23:28 2012
New Revision: 1373859
URL: http://svn.apache.org/viewvc?rev=1373859&view=rev
Log:
HADOOP-8654. TextInputFormat delimiter bug (Gelesh and Jason Lowe via bobby)
Added:
hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestLineReader.java
Modified:
hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1373859&r1=1373858&r2=1373859&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt Thu Aug 16 14:23:28 2012
@@ -395,6 +395,9 @@ Branch-2 ( Unreleased changes )
HADOOP-8659. Native libraries must build with soft-float ABI for Oracle JVM
on ARM. (Trevor Robinson via todd)
+ HADOOP-8654. TextInputFormat delimiter bug (Gelesh and Jason Lowe via
+ bobby)
+
BREAKDOWN OF HDFS-3042 SUBTASKS
HADOOP-8220. ZKFailoverController doesn't handle failure to become active
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java?rev=1373859&r1=1373858&r2=1373859&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java Thu Aug 16 14:23:28 2012
@@ -266,7 +266,8 @@ public class LineReader {
bufferPosn++;
break;
}
- } else {
+ } else if (delPosn != 0) {
+ bufferPosn--; // recheck if bufferPosn matches start of delimiter
delPosn = 0;
}
}
Added: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestLineReader.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestLineReader.java?rev=1373859&view=auto
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestLineReader.java (added)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestLineReader.java Thu Aug 16 14:23:28 2012
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.io.ByteArrayInputStream;
+
+import org.apache.hadoop.io.Text;
+import org.junit.Test;
+
+import junit.framework.Assert;
+
+public class TestLineReader {
+
+ @Test
+ public void testCustomDelimiter() throws Exception {
+ String data = "record Bangalorrecord recorrecordrecord Kerala";
+ String delimiter = "record";
+ LineReader reader = new LineReader(
+ new ByteArrayInputStream(data.getBytes()),
+ delimiter.getBytes());
+ Text line = new Text();
+ reader.readLine(line);
+ Assert.assertEquals("", line.toString());
+ reader.readLine(line);
+ Assert.assertEquals(" Bangalor", line.toString());
+ reader.readLine(line);
+ Assert.assertEquals(" recor", line.toString());
+ reader.readLine(line);
+ Assert.assertEquals("", line.toString());
+ reader.readLine(line);
+ Assert.assertEquals(" Kerala", line.toString());
+ }
+}