[GitHub] [incubator-pegasus] Shuo-Jia commented on issue #840: add 'feature flags' rcp interface for version compatability between server and client

[GitBox <gi...@apache.org>]

Shuo-Jia commented on issue #840:
URL: https://github.com/apache/incubator-pegasus/issues/840#issuecomment-1018369154


   ## 1
   > The java client may pull outdated feature list data, so we need a timer repeated scheduled function process used to continuously update the local feature list periodically...
   
   Refer to implementation `config update`,  you just update after the response of replica is `no support`. rather than boot one scheduled task
   
   ## 2
   > The server implementation is more complicated and needs to be well tested
   
   You still need implement same or more code on server side when you use the old design which client negotiation replica server, and the new design just apply the logic to meta and you can re-use `config-sync`, so I think it shouldn't be `more complicated`. 
   
   You list the update case in 
   > according to three possible situations
   
   Actually, you may not consider these different case,  the `config-sync` just `run` and store the latest value. 
   
   Just like @acelyc111 say: 
   
   > We can extend 'config_sync' betwen MS and RS to include replica server's 'feature map'
   
   
   ## 3
   
   > so the client can only start a periodically scheduled task
   
   As above, refer to implementation of `meta config` , you don't need periodically scheduled task.
   
   ## 4
   > but the business code of BATCH_GET rpc is in the pegaus
   
   They are two feature, and locate different git-rep is acceptable, it will be improved after they are combined
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org